It happens to me too often to call TestBuilder->build[_object] without 'value': $builder->build_object({ class => 'Koha::Patrons', { categorycode => $category->categorycode }); Then I am loosing minutes to understand what my tests do not fail (yes, fail). We could make it display a warning or croak or whatever.
Created attachment 89864 [details] [review] Bug 22930: Make TestBuilder->build_object explodes if parameters are wrong This patch implements bug 15339 for build_object. We want it to warn if the call is wrong. Test plan: Make sure the tests are still returning green
Created attachment 89882 [details] [review] Bug 22930: Make TestBuilder->build_object explodes if parameters are wrong This patch implements bug 15339 for build_object. We want it to warn if the call is wrong. Test plan: Make sure the tests are still returning green Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 89883 [details] [review] Bug 22930: (QA follow-up) Add two test descriptions No more than that ;) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Simple patch. Passing QA rightaway.
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.06