When refactoring additional fields for 15774 it looks like a use statement was missed
Created attachment 89893 [details] [review] Bug 22934: Add missing use statement Also fixes a typo To test: 1 - Add a subscription to a record 2 - Add an additional field in the admin section 3 - Edit the subscription and define the additional field 4 - Ensure you can view the record in the staff client and opac
Created attachment 89895 [details] [review] Bug 22934: Add missing use statement Also fixes a typo To test: 1 - Add a subscription to a record 2 - Add an additional field in the admin section 3 - Edit the subscription and define the additional field 4 - Ensure you can view the record in the staff client and opac Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 89919 [details] [review] Bug 22934: Add missing use statement Also fixes a typo To test: 1 - Add a subscription to a record 2 - Add an additional field in the admin section 3 - Edit the subscription and define the additional field 4 - Ensure you can view the record in the staff client and opac 5 - Without patch ,in the subscription detail page,click the link of the record title. => software error. 6 - Apply the patch. => no error anymore. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Created attachment 89960 [details] [review] Bug 22934: Add missing use statement Also fixes a typo To test: 1 - Add a subscription to a record 2 - Add an additional field in the admin section 3 - Edit the subscription and define the additional field 4 - Ensure you can view the record in the staff client and opac 5 - Without patch ,in the subscription detail page,click the link of the record title. => software error. 6 - Apply the patch. => no error anymore. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Fixed another typo on L21
Awesome work all! Pushed to master for 19.05
Bug with new feature not in 18.11.x series