There are quite a few validation errors coming from the OPAC detail template (opac-detail.tt), but I would like to address one with this patch: - "The aria-labelledby attribute must point to an element in the same document."
Created attachment 89943 [details] [review] Bug 22948: Markup error in OPAC bibliographic detail template This patch addresses one markup problem in opac-detail.tt which triggers a validation error. To reproduce the problem, view the normal bibliographic detail page for a record in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "The aria-labelledby attribute must point to an element in the same document." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the "Save record -> Dublin Core" menu item. It should trigger a modal window.
Created attachment 90248 [details] [review] Bug 22948: Markup error in OPAC bibliographic detail template This patch addresses one markup problem in opac-detail.tt which triggers a validation error. To reproduce the problem, view the normal bibliographic detail page for a record in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "The aria-labelledby attribute must point to an element in the same document." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the "Save record -> Dublin Core" menu item. It should trigger a modal window. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 90257 [details] [review] Bug 22948: Markup error in OPAC bibliographic detail template This patch addresses one markup problem in opac-detail.tt which triggers a validation error. To reproduce the problem, view the normal bibliographic detail page for a record in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "The aria-labelledby attribute must point to an element in the same document." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the "Save record -> Dublin Core" menu item. It should trigger a modal window. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Created attachment 90266 [details] [review] Bug 22948: Markup error in OPAC bibliographic detail template This patch addresses one markup problem in opac-detail.tt which triggers a validation error. To reproduce the problem, view the normal bibliographic detail page for a record in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "The aria-labelledby attribute must point to an element in the same document." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the "Save record -> Dublin Core" menu item. It should trigger a modal window. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Maybe something for another day/bug: FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc OK filters FAIL forbidden patterns forbidden paattern: Contains old bootstrap style for buttons (see bug 16239) (line 93)
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.01
backported to 18.11.x for 18.11.07