There is a markup error in the OPAC suggestions template (opac-suggestions.tt) which is causing a validation errors: - "End tag div seen, but there were open elements." - "Unclosed element span."
Created attachment 89946 [details] [review] Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page.
Created attachment 90092 [details] [review] Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 90242 [details] [review] Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Created attachment 90249 [details] [review] Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com>
Created attachment 90259 [details] [review] Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Current status: Signed Off Current patch-complexity: Trivial patch
Created attachment 90267 [details] [review] Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
That's a lot of sign-offs! Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.01
backported to 18.11.x for 18.11.07