If the AllowCheckoutNotes system preference is turned on, validating the user summary page in the OPAC (opac-user.pl) will return warnings: - "The name attribute is obsolete. Consider putting an id attribute on the nearest container instead."
Created attachment 89947 [details] [review] Bug 22953: Markup warning in OPAC user summary template This patch makes a minor markup change to the OPAC user summary template (opac-user.tt) in order to quiet warnings from the HTML validator. The obsolete name attribute on two links is removed in favor of class names. The JavaScript has been modified accordingly. To reproduce the problem you should have the AllowCheckoutNotes system preference enabled. Log in to the OPAC as a user who has checkouts and view the "your summary" page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses this warning: - "The name attribute is obsolete. Consider putting an id attribute on the nearest container instead." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the process of adding or editing an note on a checkout. It should work correctly.
Created attachment 90073 [details] [review] Bug 22953: Markup warning in OPAC user summary template This patch makes a minor markup change to the OPAC user summary template (opac-user.tt) in order to quiet warnings from the HTML validator. The obsolete name attribute on two links is removed in favor of class names. The JavaScript has been modified accordingly. To reproduce the problem you should have the AllowCheckoutNotes system preference enabled. Log in to the OPAC as a user who has checkouts and view the "your summary" page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses this warning: - "The name attribute is obsolete. Consider putting an id attribute on the nearest container instead." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the process of adding or editing an note on a checkout. It should work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 90128 [details] [review] Bug 22953: Markup warning in OPAC user summary template This patch makes a minor markup change to the OPAC user summary template (opac-user.tt) in order to quiet warnings from the HTML validator. The obsolete name attribute on two links is removed in favor of class names. The JavaScript has been modified accordingly. To reproduce the problem you should have the AllowCheckoutNotes system preference enabled. Log in to the OPAC as a user who has checkouts and view the "your summary" page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses this warning: - "The name attribute is obsolete. Consider putting an id attribute on the nearest container instead." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the process of adding or editing an note on a checkout. It should work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.01
backported to 18.11.x for 18.11.07