There is a minor markup error in the OPAC's "your messaging" template (opac-messaging.tt). This triggers an error in the HTML validator: - "Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag."
Created attachment 89948 [details] [review] Bug 22954: Minor markup error in OPAC messaging template This patch corrects a minor error in opac-messaging.tt in order to quiet errors returned by the HTML validator. To reproduce the problem you should have the EnhancedMessagingPreferencesOPAC system preference enabled. Log in to the OPAC and go to the "your messaging" page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses this error: - "Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag." To test, apply the patch and try again to reproduce the validation error. The error should no longer be present. There should be no visible change to the page.
Created attachment 90258 [details] [review] Bug 22954: Minor markup error in OPAC messaging template This patch corrects a minor error in opac-messaging.tt in order to quiet errors returned by the HTML validator. To reproduce the problem you should have the EnhancedMessagingPreferencesOPAC system preference enabled. Log in to the OPAC and go to the "your messaging" page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses this error: - "Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag." To test, apply the patch and try again to reproduce the validation error. The error should no longer be present. There should be no visible change to the page. Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com>
Created attachment 90261 [details] [review] Bug 22954: Minor markup error in OPAC messaging template This patch corrects a minor error in opac-messaging.tt in order to quiet errors returned by the HTML validator. To reproduce the problem you should have the EnhancedMessagingPreferencesOPAC system preference enabled. Log in to the OPAC and go to the "your messaging" page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses this error: - "Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag." To test, apply the patch and try again to reproduce the validation error. The error should no longer be present. There should be no visible change to the page. Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com>
Created attachment 90268 [details] [review] Bug 22954: Minor markup error in OPAC messaging template This patch corrects a minor error in opac-messaging.tt in order to quiet errors returned by the HTML validator. To reproduce the problem you should have the EnhancedMessagingPreferencesOPAC system preference enabled. Log in to the OPAC and go to the "your messaging" page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses this error: - "Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag." To test, apply the patch and try again to reproduce the validation error. The error should no longer be present. There should be no visible change to the page. Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.01
backported to 18.11.x for 18.11.07