This patch will remove the obsolete "type" attribute from <script> tags in the following staff client include files: - intranet-tmpl\prog\en\includes\installer-strings.inc - intranet-tmpl\prog\en\includes\password_check.inc - intranet-tmpl\prog\en\includes\slip-print.inc - intranet-tmpl\prog\en\includes\strings.inc - intranet-tmpl\prog\en\includes\timepicker.inc - intranet-tmpl\prog\en\includes\validator-strings.inc - intranet-tmpl\prog\en\includes\z3950_search.inc
Created attachment 90031 [details] [review] Bug 22973: Remove type attribute from script tags: Staff client includes 2/2 This patch removes the "type" attribute from <script> tags in several staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Installer -> Onboarding (uses installer-strings.inc, validator-strings.inc) - Patrons -> Patron details -> Change password (uses password_check.inc) - Patrons -> Patron details -> Print summary (slip-print.inc) - Circulation -> Check out (strings.inc, timepicker.inc) - Cataloging -> New from Z39.50/SRU (z3950_search.inc) Validating the HTML source of any of these pages should return no errors related to the "type" attribute.
Created attachment 90055 [details] [review] Bug 22973: Remove type attribute from script tags: Staff client includes 2/2 This patch removes the "type" attribute from <script> tags in several staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Installer -> Onboarding (uses installer-strings.inc, validator-strings.inc) - Patrons -> Patron details -> Change password (uses password_check.inc) - Patrons -> Patron details -> Print summary (slip-print.inc) - Circulation -> Check out (strings.inc, timepicker.inc) - Cataloging -> New from Z39.50/SRU (z3950_search.inc) Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Created attachment 90124 [details] [review] Bug 22973: Remove type attribute from script tags: Staff client includes 2/2 This patch removes the "type" attribute from <script> tags in several staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Installer -> Onboarding (uses installer-strings.inc, validator-strings.inc) - Patrons -> Patron details -> Change password (uses password_check.inc) - Patrons -> Patron details -> Print summary (slip-print.inc) - Circulation -> Check out (strings.inc, timepicker.inc) - Cataloging -> New from Z39.50/SRU (z3950_search.inc) Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05