This patch will remove the obsolete "type" attribute from <script> tags in the following authorities templates: - intranet-tmpl\prog\en\modules\authorities\auth_finder.tt - intranet-tmpl\prog\en\modules\authorities\authorities.tt - intranet-tmpl\prog\en\modules\authorities\blinddetail-biblio-search.tt - intranet-tmpl\prog\en\modules\authorities\detail.tt - intranet-tmpl\prog\en\modules\authorities\searchresultlist-auth.tt
Created attachment 90045 [details] [review] Bug 22979: Remove type attribute from script tags: Authorities This patch removes the "type" attribute from <script> tags in several authorities templates. Also removed: Obsolete "//<![CDATA[ //]]>" markers. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Authorities -> Search -> View authority record - Authorities -> Search -> Edit authority record - Cataloging -> New record - Trigger the authority search form by clicking the plugin link next to a tag which has been linked to an authority type (e.g. 100a -> Personal name). - Search for an authority record. - Select an authority record. Validating the HTML source of any of these pages should return no errors related to the "type" attribute.
Created attachment 90057 [details] [review] Bug 22979: Remove type attribute from script tags: Authorities This patch removes the "type" attribute from <script> tags in several authorities templates. Also removed: Obsolete "//<![CDATA[ //]]>" markers. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Authorities -> Search -> View authority record - Authorities -> Search -> Edit authority record - Cataloging -> New record - Trigger the authority search form by clicking the plugin link next to a tag which has been linked to an authority type (e.g. 100a -> Personal name). - Search for an authority record. - Select an authority record. Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Created attachment 90126 [details] [review] Bug 22979: Remove type attribute from script tags: Authorities This patch removes the "type" attribute from <script> tags in several authorities templates. Also removed: Obsolete "//<![CDATA[ //]]>" markers. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Authorities -> Search -> View authority record - Authorities -> Search -> Edit authority record - Cataloging -> New record - Trigger the authority search form by clicking the plugin link next to a tag which has been linked to an authority type (e.g. 100a -> Personal name). - Search for an authority record. - Select an authority record. Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=22797
Awesome work all! Pushed to master for 19.05