When the change for bug 21364 was made, there as some discussion about what buttons should be accessible immediately and what should be hidden in the menu. Owen's last suggestion was: The "View" part of the split button is an unnecessary duplication of the linked basket name earlier in the table. I think the actions column should have two possible buttons: "Add to basket" and "Close basket." Maybe we could implement this? As I understand it, we would remove the view part which would leave us with 2 (or 3: uncertain prices instead of close basket) buttons that show outside of a menu.
Would it make sense to have the actions menu include the same options the basket view toolbar has? - Add to basket - Edit basket - Delete basket - Close basket - Export as CSV - Create EDIFACT order - E-mail order
(In reply to Owen Leonard from comment #1) > Would it make sense to have the actions menu include the same options the > basket view toolbar has? > > - Add to basket > - Edit basket > - Delete basket > - Close basket > - Export as CSV > - Create EDIFACT order > - E-mail order I think the more urgent issue here is to make the 'add to basket' more prominent again. But I see no reason not to include them, other than the list might get a little full :)
Created attachment 97301 [details] [review] Bug 23031: Make 'add to basket' accessible in one click (fix regression) Since bug 21364 we have 'view' then 'add to basket' that is accessible in 2 clicks. We should have it directly accessible. Test plan: Create a new basket Add a new order to the basket (note that the link is directly accessible) When a new order is added you can close the basket from the basket list view Note that the dropdown button displays correctly
Created attachment 97409 [details] [review] Bug 23031: Make 'add to basket' accessible in one click (fix regression) Since bug 21364 we have 'view' then 'add to basket' that is accessible in 2 clicks. We should have it directly accessible. Test plan: Create a new basket Add a new order to the basket (note that the link is directly accessible) When a new order is added you can close the basket from the basket list view Note that the dropdown button displays correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org>
If I understand this correctly, the 'view' is on the basket name link and the 'add to order' is default action on the button?
Created attachment 98093 [details] [review] Bug 23031: Make 'add to basket' accessible in one click (fix regression) Since bug 21364 we have 'view' then 'add to basket' that is accessible in 2 clicks. We should have it directly accessible. Test plan: Create a new basket Add a new order to the basket (note that the link is directly accessible) When a new order is added you can close the basket from the basket list view Note that the dropdown button displays correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Katrin Fischer from comment #5) > If I understand this correctly, the 'view' is on the basket name link and > the 'add to order' is default action on the button? Yes, from comment 0: """ The "View" part of the split button is an unnecessary duplication of the linked basket name earlier in the table """
(In reply to Jonathan Druart from comment #7) > (In reply to Katrin Fischer from comment #5) > > If I understand this correctly, the 'view' is on the basket name link and > > the 'add to order' is default action on the button? > > Yes, from comment 0: > """ > The "View" part of the split button is an unnecessary duplication of the > linked basket name earlier in the table > """ All good then :)
Nice work everyone! Pushed to master for 20.05
Enhancement not backported to 19.11.x