Adding or editing an item, fields mapped to items.price and items.replacementprice do not obey CurrencyFormat.
You are right, but it's the same for all price/monetary amounts. Koha currently only works with decimal . Something we need to find a global fix for - changing to enh.
Created attachment 140806 [details] [review] Bug 23063: Use Price formatting on amounts in item table in cataloguing Koha can use CurrencyFormat for displaying price amounts and should do so consistently everywhere. Without this patch price and replacement cost will always display as xx.xx independent of CurrencyFormat setting in the table above the edit items form. This patch fixes the table display. To test: * Apply patch * Search or create a record with multiple items * Fill in some price and replacement costs * Try different settings of the CurrencyFormat system preference * The display in the item table above the edit/add form should display according to the system preference * Verify sorting works
Created attachment 140812 [details] [review] Bug 23063: Use Price formatting on amounts in item table in cataloguing Koha can use CurrencyFormat for displaying price amounts and should do so consistently everywhere. Without this patch price and replacement cost will always display as xx.xx independent of CurrencyFormat setting in the table above the edit items form. This patch fixes the table display. To test: * Apply patch * Search or create a record with multiple items * Fill in some price and replacement costs * Try different settings of the CurrencyFormat system preference * The display in the item table above the edit/add form should display according to the system preference * Verify sorting works Signed-off-by: David Nind <david@davidnind.com>
Thank you, David!
Created attachment 141259 [details] [review] Bug 23063: Use Price formatting on amounts in item table in cataloguing Koha can use CurrencyFormat for displaying price amounts and should do so consistently everywhere. Without this patch price and replacement cost will always display as xx.xx independent of CurrencyFormat setting in the table above the edit items form. This patch fixes the table display. To test: * Apply patch * Search or create a record with multiple items * Fill in some price and replacement costs * Try different settings of the CurrencyFormat system preference * The display in the item table above the edit/add form should display according to the system preference * Verify sorting works Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 22.11. Nice work everyone, thanks!