I don't know if this is expected behvaiour, but it feels like a bug - at the very least the label of the button should change? Or I would think 2 buttons 'New Subscription' and 'New subscription for this serial' To recreate: 1 - Go to Serials module in Koha 2 - Click 'New subscription' 3 - You get a blank form 4 - Fill it out, save it 5 - You are viewing the subscription you created 6 - Click 'New subscription' 7 - You get a form populated with the biblio of the last subscription you created
Created attachment 90439 [details] [review] Bug 23065: Rename "New subscription" button when default to current serial To make it explicite that the "New subscription" button will create a subscription based on the current serial it is now labeled "New subscription for this serial" Test plan: 1 - Go to Serials module in Koha 2 - Click 'New subscription' 3 - You get a blank form 4 - Fill it out, save it 5 - You are viewing the subscription you created => The button is now labeled "New subscription for this serial"
Created attachment 90465 [details] [review] Bug 23065: Rename "New subscription" button when default to current serial To make it explicite that the "New subscription" button will create a subscription based on the current serial it is now labeled "New subscription for this serial" Test plan: 1 - Go to Serials module in Koha 2 - Click 'New subscription' 3 - You get a blank form 4 - Fill it out, save it 5 - You are viewing the subscription you created => The button is now labeled "New subscription for this serial" Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 90575 [details] [review] Bug 23065: Rename "New subscription" button when default to current serial To make it explicite that the "New subscription" button will create a subscription based on the current serial it is now labeled "New subscription for this serial" Test plan: 1 - Go to Serials module in Koha 2 - Click 'New subscription' 3 - You get a blank form 4 - Fill it out, save it 5 - You are viewing the subscription you created => The button is now labeled "New subscription for this serial" Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.02
backported to 18.11.x for 18.11.08