From the following commit: commit d1303ca834dd0b08fc1d44476cfbbb8b729b6165 Bug 18925: (follow-up) Fix null/empty behavior The global test must have been adjusted as well to catch empty strings. Actually we are expecting the plugin to return undef but the template variable contains an empty string. So the test should only be [% IF var != '' %] instead of [% IF var.defined && var != '' %] but I prefer to keep it as it for now.
Created attachment 90502 [details] [review] Bug 23095: Correctly display circulation rules (0 vs undef) From the following commit: commit d1303ca834dd0b08fc1d44476cfbbb8b729b6165 Bug 18925: (follow-up) Fix null/empty behavior The global test must have been adjusted as well to catch empty strings. Actually we are expecting the plugin to return undef but the template variable contains an empty string. So the test should only be [% IF var != '' %] instead of [% IF var.defined && var != '' %] but I prefer to keep it as it for now. Test plan: In the section "Default checkout, hold policy by patron category" Set total checkouts = blank total on-site checkouts = blank total holds = 0 Save => Without this patch the line will not appear => With this patch applied there must be "unlimited, unlimited, 0"
Created attachment 90510 [details] [review] Bug 23095: Correctly display circulation rules (0 vs undef) From the following commit: commit d1303ca834dd0b08fc1d44476cfbbb8b729b6165 Bug 18925: (follow-up) Fix null/empty behavior The global test must have been adjusted as well to catch empty strings. Actually we are expecting the plugin to return undef but the template variable contains an empty string. So the test should only be [% IF var != '' %] instead of [% IF var.defined && var != '' %] but I prefer to keep it as it for now. Test plan: In the section "Default checkout, hold policy by patron category" Set total checkouts = blank total on-site checkouts = blank total holds = 0 Save => Without this patch the line will not appear => With this patch applied there must be "unlimited, unlimited, 0" Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
(In reply to Jonathan Druart from comment #1) > Actually we are expecting the plugin to return undef but the template > variable contains an empty string. That's wrong, it's an empty string in DB.
I don't manage to reproduce it. I'm sure I'm doing something wrong, but just followed the test steps.
Created attachment 90540 [details] [review] Bug 23095: Correctly display circulation rules (0 vs undef) From the following commit: commit d1303ca834dd0b08fc1d44476cfbbb8b729b6165 Bug 18925: (follow-up) Fix null/empty behavior The global test must have been adjusted as well to catch empty strings. Actually we are expecting the plugin to return undef but the template variable contains an empty string. So the test should only be [% IF var != '' %] instead of [% IF var.defined && var != '' %] but I prefer to keep it as it for now. Test plan: In the section "Default checkout, hold policy by patron category" Set total checkouts = blank total on-site checkouts = blank total holds = 0 Save => Without this patch the line will not appear => With this patch applied there must be "unlimited, unlimited, 0" Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.01
no backport for 18.11.x series as it is missing the dependency