To match the updated OPAC search results page, the toolbar on the OPAC list contents table should be a floating toolbar.
Created attachment 90512 [details] [review] Bug 23096: Add floating toolbar to OPAC lists This patch makes the list contents table's toolbar "stick" to the top of the screen when scrolling. Minor markup changes have been made to enable this change. To test, apply the patch and open a list in the OPAC which has multiple titles on it. Confirm that the toolbar sticks to the top of the screen when you scroll down.
Patch doesn't apply. Unfortunately, the content toolbar doesn't stick to the top. No specific error message while applying the patch.
This applies fine for me, so please re-test if you can. Note that it depends on Bug 5287 which requires that you rebuild the OPAC CSS.
Comment on attachment 90512 [details] [review] Bug 23096: Add floating toolbar to OPAC lists Review of attachment 90512 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc @@ +90,4 @@ > </ul> > > <!-- Dublin Core Modal Form --> > +<div class="foo modal hide" id="exportModal_" tabindex="-1" role="dialog" aria-labelledby="exportModalLabel" aria-hidden="true"> foo seems out of place.
Failing as per Owen's suggestion, since foo is out of place.
Created attachment 90755 [details] [review] Bug 23096: Add floating toolbar to OPAC lists This patch makes the list contents table's toolbar "stick" to the top of the screen when scrolling. Minor markup changes have been made to enable this change. To test, apply the patch and open a list in the OPAC which has multiple titles on it. Confirm that the toolbar sticks to the top of the screen when you scroll down.
Created attachment 90763 [details] [review] Bug 23096: Add floating toolbar to OPAC lists This patch makes the list contents table's toolbar "stick" to the top of the screen when scrolling. Minor markup changes have been made to enable this change. To test, apply the patch and open a list in the OPAC which has multiple titles on it. Confirm that the toolbar sticks to the top of the screen when you scroll down. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
While it does scroll, there is a gap, that is distracting when things scroll through it.
Rebuilding the OPAC CSS is part of the test plan for Bug 5287. That makes the patches work correctly.
Created attachment 90964 [details] [review] Bug 23096: Add floating toolbar to OPAC lists This patch makes the list contents table's toolbar "stick" to the top of the screen when scrolling. Minor markup changes have been made to enable this change. To test, apply the patch and open a list in the OPAC which has multiple titles on it. Confirm that the toolbar sticks to the top of the screen when you scroll down. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work! Pushed to master for 19.11.00
Depends on Bug 5287 not pushed to 19.05.x