During the KOC upload process, after a user clicks "Upload", Koha will return "Your file was processed". This is somewhat misleading and implies the process is over. When looking at pending offline circulation actions that button also says "Process", so staff that do this rarely may get them confused and stop the process too early. I suggest changing the wording to "Your file was uploaded. Once all files are uploaded, please process them in pending offline circulation actions." or something to that effect.
Agreed. The wording is confusing and we had some trouble with this very problem this weekend. Lisette
Created attachment 90704 [details] [review] Bug 23098: Reword success message of KOC upload process When uploading KOC files the processing of transactions needs to happen in a separate second step. This is why the success message "Your file was processed" was found to be misleading. This patch changes it to the wording suggested by Benjamin Daeuber in the original bug report. Thx! To test: - Create a KOC file either manually or by downloading it from the plugin - Upload the KOC file into Koha using Circulation > Upload offline circulation file (.koc) - Verify the new message is clear and has no typos :)
Hi Lisette and Benjamin, I've changed the message, hope that works for you!
Created attachment 90866 [details] [review] Bug 23098: Reword success message of KOC upload process When uploading KOC files the processing of transactions needs to happen in a separate second step. This is why the success message "Your file was processed" was found to be misleading. This patch changes it to the wording suggested by Benjamin Daeuber in the original bug report. Thx! To test: - Create a KOC file either manually or by downloading it from the plugin - Upload the KOC file into Koha using Circulation > Upload offline circulation file (.koc) - Verify the new message is clear and has no typos :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Only thing that was a little off was the processing AFTER this, the check/uncheck doesn't disappear once the success message appears in the first column. But that is beyond the scope of this bug.
Created attachment 90907 [details] [review] Bug 23098: Reword success message of KOC upload process When uploading KOC files the processing of transactions needs to happen in a separate second step. This is why the success message "Your file was processed" was found to be misleading. This patch changes it to the wording suggested by Benjamin Daeuber in the original bug report. Thx! To test: - Create a KOC file either manually or by downloading it from the plugin - Upload the KOC file into Koha using Circulation > Upload offline circulation file (.koc) - Verify the new message is clear and has no typos :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.03
backported to 18.11.x for 18.11.09