I think this button is supposed to be hidden, but it seems to flash on/off when the page loads. It'd probably be tidier if it didn't do that.
Created attachment 90516 [details] [review] Bug 23099: OPAC Search result sorting "go" button flashes on page load There are a few places in the OPAC where we hide the submit button on a sorting form because the form auto-submits when the selection changes. These should be hidden using CSS instead of JS to prevent the temporary appearance of the submit button while the page loads. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test OPAC search results and OPAC checkout history. On both pages you should not see a "Go" button next to the <select> input for changing the sort order. Disable JavaScript in your browser and test those pages again. The "Go" button should appear.
Created attachment 91723 [details] [review] This is much better. CSS is always greater than jQuery in these instances. Bug 23099: OPAC Search result sorting "go" button flashes on page load There are a few places in the OPAC where we hide the submit button on a sorting form because the form auto-submits when the selection changes. These should be hidden using CSS instead of JS to prevent the temporary appearance of the submit button while the page loads. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test OPAC search results and OPAC checkout history. On both pages you should not see a "Go" button next to the <select> input for changing the sort order. Disable JavaScript in your browser and test those pages again. The "Go" button should appear. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 91865 [details] [review] Bug 23099: OPAC Search result sorting "go" button flashes on page load There are a few places in the OPAC where we hide the submit button on a sorting form because the form auto-submits when the selection changes. These should be hidden using CSS instead of JS to prevent the temporary appearance of the submit button while the page loads. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test OPAC search results and OPAC checkout history. On both pages you should not see a "Go" button next to the <select> input for changing the sort order. Disable JavaScript in your browser and test those pages again. The "Go" button should appear. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work! Pushed to master for 19.11.00
Small enhancement, I choose to backport. Pushed to 19.05.x for 19.05.03
backported to 18.11.x for 18.11.10