---- Reported by nengard@gmail.com 2008-07-07 08:29:30 ---- When you want to delete a MARC record that has items attached the Delete option is grayed out, but there is no explanation for the user. We should add a note about this to the menu. PER CHAT: <nengard> gmcharlt I got a request to write in the manual about deleting marc records - he said that delete was sometimes grayed out - i told him it was cause items were attached to the record - was it you i talked to this about before?? <gmcharlt> nengard: dunno. <nengard> hehe <gmcharlt> nengard: could make it say "can't delete - items attached" or something like that in addition to greying it out <nengard> i can't find any documentation on it and i know i talked to one of you guys about it - am i right about why it's grayed out? <gmcharlt> nengard: lemme check <nengard> gmcharlt - yeah - that's what i remember - talking to one of you about adding that note .... but i don't have a bug report for it <gmcharlt> nengard: just checked - yes, appears is tied to whether bib has items attached ---- Additional Comments From oleonard@myacpl.org 2008-07-08 11:19:06 ---- I have some ideas for an interface tweak to address this bug, but it would require changes to the templates that would create problems for translators this close to the final release. I'm moving this to rel_3_2. ---- Additional Comments From oleonard@myacpl.org 2008-07-09 07:41:47 ---- Created an attachment Menu showing disabled items. Will the question mark encourage the user to click for more information? ---- Additional Comments From oleonard@myacpl.org 2008-07-09 07:42:24 ---- Created an attachment Clicking a disabled menu item offers additional information on why it is disabled ---- Additional Comments From gmcharlt@gmail.com 2008-07-09 07:45:09 ---- I'm not sure that a question mark is enough - some indication of why a menu item is disabled that doesn't involve another click would be better IMO. If brief text explanations are too long, maybe create a set of icons for things like * disabled because operator doesn't have permission * disabled due to other policy setting * disabled because of transaction limits ---- Additional Comments From oleonard@myacpl.org 2008-07-09 08:17:33 ---- Created an attachment Another alternative: disabled menu item with tooltip ---- Additional Comments From oleonard@myacpl.org 2008-07-09 08:22:11 ---- I don't think adding a special icon for each one would solve the problem of not needing another click because users wouldn't know what the icons mean without some additional information. Then you're back to having to offer something, a js alert or tooltip, to let them know. I'm just not confident that 16x16 icons can be created that express the reasons you list. ---- Additional Comments From gmcharlt@gmail.com 2008-07-09 08:23:25 ---- I agree that creating new icons is not ideal. Tooltips should work, though. --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:49 UTC --- This bug was previously known as _bug_ 2310 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2310 Imported an attachment (id=610) Imported an attachment (id=611) Imported an attachment (id=612) Actual time not defined. Setting to 0.0 CC member bchurch@ptfs.com does not have an account here The original submitter of attachment 610 [details] is unknown. Reassigning to the person who moved it here: chris@bigballofwax.co.nz. The original submitter of attachment 611 [details] is unknown. Reassigning to the person who moved it here: chris@bigballofwax.co.nz. The original submitter of attachment 612 [details] is unknown. Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
Is this bug still valid?
There are still instances where this bug should be fixed. The first example, bibliographic records which have items attached, has been fixed with a javascript alert() explaining that the record still has items attached. I see three places where this needs to be fixed: - patron deletion - update child to adult patron - delete subscription
Created attachment 22195 [details] [review] Bug 2310 - Delete grayed out w/out explanation With some staff client menus options are displayed as disabled when the logged in user doesn't have permission to perform that function. This patch adds Bootstrap tooltips to patron menu items with text explaining why they are disabled. To test, log in as a user who lacks permission to modify patrons or set permissions. Open a patron record in circulation or patrons. Hovering over renew, delete, and set permissions links (in the patron toolbar "More" menu) should trigger a tooltip with a brief explanation. Test the "Update child to adult patron" link by viewing an adult patron. A separate patch will address catalog menu items.
OR -- we could hide the menu items altogether. We do this with toolbar buttons and global "More" menu items. Opinions?
Hmm... Upon reflection, the reason we previously didn't consider the option of hiding menu options altogether was probably that the template couldn't handle the logic required to hide the whole "More" menu if no options were available. This I'm guessing is now moot, not least because the "export checked in barcodes" item isn't controlled by any permission.
Created attachment 22419 [details] [review] Bug 2310 - Delete grayed out w/out explanation With some staff client menus options are displayed as disabled when the logged in user doesn't have permission to perform that function. This patch adds Bootstrap tooltips to patron menu items with text explaining why they are disabled. To test, log in as a user who lacks permission to modify patrons or set permissions. Open a patron record in circulation or patrons. Hovering over renew, delete, and set permissions links (in the patron toolbar "More" menu) should trigger a tooltip with a brief explanation. Test the "Update child to adult patron" link by viewing an adult patron. A separate patch will address catalog menu items. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Great design!
Created attachment 22456 [details] [review] [PASSED QA] Bug 2310 - Delete grayed out w/out explanation With some staff client menus options are displayed as disabled when the logged in user doesn't have permission to perform that function. This patch adds Bootstrap tooltips to patron menu items with text explaining why they are disabled. To test, log in as a user who lacks permission to modify patrons or set permissions. Open a patron record in circulation or patrons. Hovering over renew, delete, and set permissions links (in the patron toolbar "More" menu) should trigger a tooltip with a brief explanation. Test the "Update child to adult patron" link by viewing an adult patron. A separate patch will address catalog menu items. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> New tooltip texts are translatable, patch passes all tests and QA script. Tested according to test plan in Chromium and Firefox.
Pushed to master. Thanks, Owen!
Comment on attachment 22456 [details] [review] [PASSED QA] Bug 2310 - Delete grayed out w/out explanation Looks like this bug is an omnibus, so obsoleting the patch that was pushed and setting back to assigned.
Commit : 01c101a Bug 2310: display tooltips explaining why patron menu items are disabled Pushed to 3.14.x, will be in 3.14.1
This patch (display tooltips explaining why patron menu items are disabled) has been pushed to 3.12.x, will be in 3.12.9. Thanks Owen!
Why is this bug assigned again ?
(In reply to Fridolin SOMERS from comment #12) > Why is this bug assigned again ? See comment 9.
(In reply to Galen Charlton from comment #13) > See comment 9. Ok, omnibus. Thanks.
No movement here for a long time, can this omnibus be closed?