Bug 2310 - Omnibus: Delete grayed out w/out explanation
Summary: Omnibus: Delete grayed out w/out explanation
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P3 normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on: 16230
Blocks: 8149
  Show dependency treegraph
 
Reported: 2008-07-07 08:29 UTC by Nicole C. Engard
Modified: 2018-12-03 20:03 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Menu showing disabled items. Will the question mark encourage the user to click for more information? (3.85 KB, image/gif)
2008-07-09 07:41 UTC, Chris Cormack
Details
Clicking a disabled menu item offers additional information on why it is disabled (5.70 KB, image/gif)
2008-07-09 07:42 UTC, Chris Cormack
Details
Another alternative: disabled menu item with tooltip (3.97 KB, image/gif)
2008-07-09 08:17 UTC, Chris Cormack
Details
Bug 2310 - Delete grayed out w/out explanation (4.38 KB, patch)
2013-10-21 21:38 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 2310 - Delete grayed out w/out explanation (4.40 KB, patch)
2013-10-25 16:21 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 2310 - Delete grayed out w/out explanation (4.59 KB, patch)
2013-10-27 19:31 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:49:13 UTC


---- Reported by nengard@gmail.com 2008-07-07 08:29:30 ----

When you want to delete a MARC record that has items attached the Delete option is grayed out, but there is no explanation for the user.  We should add a note about this to the menu.

PER CHAT: 

<nengard> gmcharlt I got a request to write in the manual about deleting marc records - he said that delete was sometimes grayed out - i told him it was cause items were attached to the record - was it you i talked to this about before??
 <gmcharlt> nengard: dunno.
 <nengard> hehe
 <gmcharlt> nengard: could make it say "can't delete - items attached" or something like that in addition to greying it out
 <nengard> i can't find any documentation on it and i know i talked to one of you guys about it - am i right about why it's grayed out?
 <gmcharlt> nengard: lemme check 
 <nengard> gmcharlt - yeah - that's what i remember - talking to one of you about adding that note .... but i don't have a bug report for it
 <gmcharlt> nengard: just checked - yes, appears is tied to whether bib has items attached



---- Additional Comments From oleonard@myacpl.org 2008-07-08 11:19:06 ----

I have some ideas for an interface tweak to address this bug, but it would require changes to the templates that would create problems for translators this close to the final release. I'm moving this to rel_3_2.



---- Additional Comments From oleonard@myacpl.org 2008-07-09 07:41:47 ----

Created an attachment
Menu showing disabled items. Will the question mark encourage the user to click for more information?





---- Additional Comments From oleonard@myacpl.org 2008-07-09 07:42:24 ----

Created an attachment
Clicking a disabled menu item offers additional information on why it is disabled





---- Additional Comments From gmcharlt@gmail.com 2008-07-09 07:45:09 ----

I'm not sure that a question mark is enough - some indication of why a menu item is disabled that doesn't involve another click would be better IMO.  If brief text explanations are too long, maybe create a set of icons for things like

* disabled because operator doesn't have permission
* disabled due to other policy setting
* disabled because of transaction limits



---- Additional Comments From oleonard@myacpl.org 2008-07-09 08:17:33 ----

Created an attachment
Another alternative: disabled menu item with tooltip





---- Additional Comments From oleonard@myacpl.org 2008-07-09 08:22:11 ----

I don't think adding a special icon for each one would solve the problem of not needing another click because users wouldn't know what the icons mean without some additional information. Then you're back to having to offer something, a js alert or tooltip, to let them know. I'm just not confident that 16x16 icons can be created that express the reasons you list.



---- Additional Comments From gmcharlt@gmail.com 2008-07-09 08:23:25 ----

I agree that creating new icons is not ideal.  Tooltips should work, though.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:49 UTC  ---

This bug was previously known as _bug_ 2310 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2310
Imported an attachment (id=610)
Imported an attachment (id=611)
Imported an attachment (id=612)

Actual time not defined. Setting to 0.0
CC member bchurch@ptfs.com does not have an account here
The original submitter of attachment 610 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 611 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 612 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Katrin Fischer 2011-04-25 08:45:21 UTC
Is this bug still valid?
Comment 2 Owen Leonard 2011-04-25 12:51:48 UTC
There are still instances where this bug should be fixed. The first example, bibliographic records which have items attached, has been fixed with a javascript alert() explaining that the record still has items attached.

I see three places where this needs to be fixed:

- patron deletion
- update child to adult patron
- delete subscription
Comment 3 Owen Leonard 2013-10-21 21:38:07 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2013-10-21 21:39:39 UTC
OR -- we could hide the menu items altogether. We do this with toolbar buttons and global "More" menu items. Opinions?
Comment 5 Owen Leonard 2013-10-21 21:54:11 UTC
Hmm... Upon reflection, the reason we previously didn't consider the option of hiding menu options altogether was probably that the template couldn't handle the logic required to hide the whole "More" menu if no options were available. This I'm guessing is now moot, not least because the "export checked in barcodes" item isn't controlled by any permission.
Comment 6 Kyle M Hall 2013-10-25 16:21:51 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2013-10-27 19:31:26 UTC Comment hidden (obsolete)
Comment 8 Galen Charlton 2013-12-05 16:39:19 UTC
Pushed to master.  Thanks, Owen!
Comment 9 Galen Charlton 2013-12-05 16:40:33 UTC
Comment on attachment 22456 [details] [review]
[PASSED QA] Bug 2310 - Delete grayed out w/out explanation

Looks like this bug is an omnibus, so obsoleting the patch that was pushed and setting back to assigned.
Comment 10 Fridolin Somers 2013-12-17 17:17:53 UTC
Commit :
  01c101a Bug 2310: display tooltips explaining why patron menu items are disabled
Pushed to 3.14.x, will be in 3.14.1
Comment 11 Tomás Cohen Arazi 2013-12-27 18:49:22 UTC
This patch (display tooltips explaining why patron menu items are disabled) has been pushed to 3.12.x, will be in 3.12.9.

Thanks Owen!
Comment 12 Fridolin Somers 2014-02-26 18:12:28 UTC
Why is this bug assigned again ?
Comment 13 Galen Charlton 2014-02-26 18:20:10 UTC
(In reply to Fridolin SOMERS from comment #12)
> Why is this bug assigned again ?

See comment 9.
Comment 14 Fridolin Somers 2014-02-26 18:42:14 UTC
(In reply to Galen Charlton from comment #13)
> See comment 9.
Ok, omnibus. Thanks.
Comment 15 Katrin Fischer 2018-05-15 22:55:36 UTC
No movement here for a long time, can this omnibus be closed?