We currently display the unapplied credit lines (along with an 'apply credit' button) above the 'Total' line and then we include the un-applied credit amount in the total amount. This is confusing to the end user.
Do you think it would be more clear to show both the pre-credit total and what the total would be after the credit is applied? Or to just show the pre-credit total? I'm honestly not sure.
I personally think both with a clear descriptive label on each.. I'd probably put the initial total above the credit lines you can apply and then the reduced total below it. I'd really love to see the ability to select which debts you apply each credit to too at some point.
Created attachment 90562 [details] Proposal
Created attachment 90563 [details] [review] Bug 23106: Tweak display of totals on payment page This patch tweaks the display of totals on the fines payments page to clarify between the totals before and after applying credits. Test Plan: 1) Add some debts and credits to a patrons account 2) Look at the pay page before applying the patch 3) Look at the pay page after applying the patch 4) Varify the new layout is an improvment or not Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 90600 [details] [review] Bug 23106: Tweak display of totals on payment page This patch tweaks the display of totals on the fines payments page to clarify between the totals before and after applying credits. Test Plan: 1) Add some debts and credits to a patrons account 2) Look at the pay page before applying the patch 3) Look at the pay page after applying the patch 4) Verify the new layout is an improvment or not Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 90621 [details] [review] Bug 23106: Tweak display of totals on payment page This patch tweaks the display of totals on the fines payments page to clarify between the totals before and after applying credits. Test Plan: 1) Add some debts and credits to a patrons account 2) Look at the pay page before applying the patch 3) Look at the pay page after applying the patch 4) Verify the new layout is an improvment or not Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 90625 [details] [review] Bug 23106: Tweak display of totals on payment page This patch tweaks the display of totals on the fines payments page to clarify between the totals before and after applying credits. Test Plan: 1) Add some debts and credits to a patrons account 2) Look at the pay page before applying the patch 3) Look at the pay page after applying the patch 4) Verify the new layout is an improvment or not Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.03
doesn't apply cleanly to 18.11.x and the rebase is a tad tricky for me, I don't want to ruin fines and credits therefore I am not backporting to 18.11.x.