On member-flags.pl, the descriptive text for the staffaccess permission reads "Allow staff members to modify permissions for other staff members." However, this permission also controls the ability to change the password of other staff members. I'd like to see it changed to read "Allow staff members to modify permissions and passwords for other staff members."
Created attachment 90706 [details] [review] Bug 23109: Improve description of staffaccess permission Changes: Allow staff members to modify permissions for other staff members To: Allow staff members to modify permissions and passwords for other staff members. As suggested by Andre on the initial bug report. To test: - Go to any patron account and check More > permissions - Veriy the description is shown as noted above - Apply patch and run database update - Reload the page and verify the description has changed - Run the following SQL and verify the description in the database table matches as well: SELECT * FROM userflags where flag = "staffaccess";
Created attachment 90860 [details] [review] Bug 23109: (follow-up) fix typo in upgrade script
Created attachment 90861 [details] [review] Bug 23109: Improve description of staffaccess permission Changes: Allow staff members to modify permissions for other staff members To: Allow staff members to modify permissions and passwords for other staff members. As suggested by Andre on the initial bug report. To test: - Go to any patron account and check More > permissions - Veriy the description is shown as noted above - Apply patch and run database update - Reload the page and verify the description has changed - Run the following SQL and verify the description in the database table matches as well: SELECT * FROM userflags where flag = "staffaccess"; Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 90862 [details] [review] Bug 23109: (follow-up) fix typo in upgrade script Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Thx for the follow-up!
Created attachment 90961 [details] [review] Bug 23109: Improve description of staffaccess permission Changes: Allow staff members to modify permissions for other staff members To: Allow staff members to modify permissions and passwords for other staff members. As suggested by Andre on the initial bug report. To test: - Go to any patron account and check More > permissions - Veriy the description is shown as noted above - Apply patch and run database update - Reload the page and verify the description has changed - Run the following SQL and verify the description in the database table matches as well: SELECT * FROM userflags where flag = "staffaccess"; Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 90962 [details] [review] Bug 23109: (follow-up) fix typo in upgrade script Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I am not sure we should care about the description in DB (as it is not used on the interface) but it will not hurt.
Nice work! Pushed to master for 19.11.00
Not pushed to 19.05.x Its minor and I prefer avoid db changes in stable branch.