We noticed that the status AVAILABLE (suggestion was ordered and received in acq) is not displayed correctly in the suggestions table. I think it's missing in the templates here: 131 <span class="label">Status:</span> 132 [% SET status_found = 0 %] 133 [% IF ( STATUS == 'ASKED' ) %] 134 Pending 135 [% SET status_found = 1 %] 136 [% ELSIF ( STATUS == 'ACCEPTED' ) %] 137 Accepted 138 [% SET status_found = 1 %] 139 [% ELSIF ( STATUS == 'CHECKED' ) %] 140 Checked 141 [% SET status_found = 1 %] 142 [% ELSIF ( STATUS == 'REJECTED' ) %] 143 Rejected 144 [% SET status_found = 1 %] 145 [% ELSE %] 146 [% FOREACH s IN SuggestionStatuses %] 147 [% IF STATUS == s.authorised_value %] 148 [% s.lib | html %] 149 [% SET status_found = 1 %] 150 [% END %] 151 [% END %] 152 [% END %] It shows as AVAILABLE and is not translatable.
ORDERED is missing as well.
This part of the code looks incomplete as well: 506 <td> 507 [% IF ( suggestions_loo.ASKED ) %] 508 Pending 509 [% ELSIF ( suggestions_loo.ACCEPTED ) %] 510 Accepted 511 [% ELSIF ( suggestions_loo.ORDERED ) %] 512 Ordered 513 [% ELSIF ( suggestions_loo.REJECTED ) %] 514 Rejected 515 [% ELSIF ( suggestions_loo.CHECKED ) %] 516 Checked 517 [% ELSIF AuthorisedValues.GetByCode( 'SUGGEST_STATUS', suggestions_loo.STATUS ) %] 518 [% AuthorisedValues.GetByCode( 'SUGGEST_STATUS', suggestions_loo.STATUS ) | html %] 519 [% ELSE %] 520 Status unknown 521 [% END %] 522 523 [% IF ( suggestions_loo.reason ) %] 524 <br />([% suggestions_loo.reason | html %]) 525 [% END %] 526 </td>
Created attachment 91514 [details] [review] Bug 23123: Add missing suggestion status to template for translation This completes suggestion status options in the templates in 2 places so all values can be translated and show correctly. To test: - Create 2 suggestions - Accept them - Create a basket and order those 2 from suggestions - Close the basket - Receive shipment and receive one of the 2 suggestions - Go back to suggestions: - Look at the status column in the suggestions table for both - Verify that it shows AVAILABLE - View both suggestions - Verify that the Status: is empty - Apply patch - Repeat test from above, it should all show nicely now
Created attachment 93444 [details] [review] Bug 23123: Add missing suggestion status to template for translation This completes suggestion status options in the templates in 2 places so all values can be translated and show correctly. To test: - Create 2 suggestions - Accept them - Create a basket and order those 2 from suggestions - Close the basket - Receive shipment and receive one of the 2 suggestions - Go back to suggestions: - Look at the status column in the suggestions table for both - Verify that it shows AVAILABLE - View both suggestions - Verify that the Status: is empty - Apply patch - Repeat test from above, it should all show nicely now Signed-off-by: Claudie Trégouët <claudie.tregouet@biblibre.com>
Thank you, Claudie!
Created attachment 93582 [details] [review] Bug 23123: Add missing suggestion status to template for translation This completes suggestion status options in the templates in 2 places so all values can be translated and show correctly. To test: - Create 2 suggestions - Accept them - Create a basket and order those 2 from suggestions - Close the basket - Receive shipment and receive one of the 2 suggestions - Go back to suggestions: - Look at the status column in the suggestions table for both - Verify that it shows AVAILABLE - View both suggestions - Verify that the Status: is empty - Apply patch - Repeat test from above, it should all show nicely now Signed-off-by: Claudie Trégouët <claudie.tregouet@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work! Pushed to master for 19.11.00