The commented out alternative mana KB server URL included in etc/koha-conf.xml is not correct. If it is used it generates an error message when submitting an account creation request, and the account creation request fails. Error message: 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "<html>\r\n<head><tit...") at /usr/share/perl5/JSON.pm line 171.'
The URL should start with https instead of http: - Current URL: <!-- alternative value http://mana-test.koha-community.org to query the test server --> - Corrected URL: <!-- alternative value https://mana-test.koha-community.org to query the test server --> To replicate the issue: 1) Add <mana_config>http://mana-test.koha-community.org</mana_config> to /etc/koha/sites/<instancename>/koha-conf.xml (see etc/koha-conf.xml in the Koha code repository for an example of where to add this; <instancename> if using koha-testing-docker is kohadev). 2) Clear memcached and restart services so that the changes to your Koha instance configuration are recognised (if using koha-testing-docker run flush_memcached and then restart_all). 3) From the staff client home page go to Koha administration > Additional parameters > Share content with Mana KB. 4) Enable content sharing: change 'Use Mana KB for sharing content' to Yes and press Save. 5) Enter your first name, last name and email address in the Configure Mana KB section of the page and then click on 'Send to Mana KB'. 6) An error message is displayed, this may be something like 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "<html>\r\n<head><tit...") at /usr/share/perl5/JSON.pm line 171.'. 7) Change the mana server URL to https://mana-test.koha-community.org (see step 1), and repeat steps 2, 3 and 5. 8) Instead of an error message you should get 'You successfully created your Mana KB account. Check your mailbox and follow instructions.'
Created attachment 90635 [details] [review] Bug 23130: Fix alternative mana server URL in etc/koha-conf.xml If the alternative mana KB server URL in etc/koha-conf.xml is used it causes an error message like 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "<html>\r\n<head><tit...") at /usr/share/perl5/JSON.pm line 171.' when submitting an account creation request, and the account creation request fails. This patch updates the alternative mana KB server URL in etc/koha-conf.xml from http://mana-test.koha-community.org to https://mana-test.koha-community.org (the URL should start with https instead of http). If the updated URL is used the account creation request succeeds without causing any error messages. To test: 1) Add <mana_config>http://mana-test.koha-community.org</mana_config> to /etc/koha/sites/<instancename>/koha-conf.xml (see etc/koha-conf.xml in the Koha code repository for an example of where to add this; <instancename> if using koha-testing-docker is kohadev). 2) Clear memcached and restart services so that the changes to your Koha instance configuration are recognised (if using koha-testing-docker run flush_memcached and then restart_all). 3) From the staff client home page go to Koha administration > Additional parameters > Share content with Mana KB. 4) Enable content sharing: change 'Use Mana KB for sharing content' to Yes and press Save. 5) Enter your first name, last name and email address in the Configure Mana KB section of the page and then click on 'Send to Mana KB'. 6) An error message is displayed, this may be something like: 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "<html>\r\n<head><tit...") at /usr/share/perl5/JSON.pm line 171.' 7) Change the mana server URL to https://mana-test.koha-community.org (see step 1), and repeat steps 2, 3 and 5. 8) Instead of an error message you should get 'You successfully created your Mana KB account. Check your mailbox and follow instructions.'
Created attachment 90707 [details] [review] Bug 23130: Fix alternative mana server URL in etc/koha-conf.xml If the alternative mana KB server URL in etc/koha-conf.xml is used it causes an error message like 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "<html>\r\n<head><tit...") at /usr/share/perl5/JSON.pm line 171.' when submitting an account creation request, and the account creation request fails. This patch updates the alternative mana KB server URL in etc/koha-conf.xml from http://mana-test.koha-community.org to https://mana-test.koha-community.org (the URL should start with https instead of http). If the updated URL is used the account creation request succeeds without causing any error messages. To test: 1) Add <mana_config>http://mana-test.koha-community.org</mana_config> to /etc/koha/sites/<instancename>/koha-conf.xml (see etc/koha-conf.xml in the Koha code repository for an example of where to add this; <instancename> if using koha-testing-docker is kohadev). 2) Clear memcached and restart services so that the changes to your Koha instance configuration are recognised (if using koha-testing-docker run flush_memcached and then restart_all). 3) From the staff client home page go to Koha administration > Additional parameters > Share content with Mana KB. 4) Enable content sharing: change 'Use Mana KB for sharing content' to Yes and press Save. 5) Enter your first name, last name and email address in the Configure Mana KB section of the page and then click on 'Send to Mana KB'. 6) An error message is displayed, this may be something like: 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "<html>\r\n<head><tit...") at /usr/share/perl5/JSON.pm line 171.' 7) Change the mana server URL to https://mana-test.koha-community.org (see step 1), and repeat steps 2, 3 and 5. 8) Instead of an error message you should get 'You successfully created your Mana KB account. Check your mailbox and follow instructions.' Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
It appears that http: now forwards to https:, but it's still nice to have this!
Created attachment 90784 [details] [review] Bug 23130: Fix alternative mana server URL in etc/koha-conf.xml If the alternative mana KB server URL in etc/koha-conf.xml is used it causes an error message like 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "<html>\r\n<head><tit...") at /usr/share/perl5/JSON.pm line 171.' when submitting an account creation request, and the account creation request fails. This patch updates the alternative mana KB server URL in etc/koha-conf.xml from http://mana-test.koha-community.org to https://mana-test.koha-community.org (the URL should start with https instead of http). If the updated URL is used the account creation request succeeds without causing any error messages. To test: 1) Add <mana_config>http://mana-test.koha-community.org</mana_config> to /etc/koha/sites/<instancename>/koha-conf.xml (see etc/koha-conf.xml in the Koha code repository for an example of where to add this; <instancename> if using koha-testing-docker is kohadev). 2) Clear memcached and restart services so that the changes to your Koha instance configuration are recognised (if using koha-testing-docker run flush_memcached and then restart_all). 3) From the staff client home page go to Koha administration > Additional parameters > Share content with Mana KB. 4) Enable content sharing: change 'Use Mana KB for sharing content' to Yes and press Save. 5) Enter your first name, last name and email address in the Configure Mana KB section of the page and then click on 'Send to Mana KB'. 6) An error message is displayed, this may be something like: 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "<html>\r\n<head><tit...") at /usr/share/perl5/JSON.pm line 171.' 7) Change the mana server URL to https://mana-test.koha-community.org (see step 1), and repeat steps 2, 3 and 5. 8) Instead of an error message you should get 'You successfully created your Mana KB account. Check your mailbox and follow instructions.' Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Nice work! Pushed to master for 19.11.00
Congratulations on your first patch David, it's great to have you aboard :)
Pushed to 19.05.x for 19.05.02