Currently in the circulation Holds Ratio report that is found in the Circulation module, the ratio defaults to 2. It would be nice to be able to specify what a library would like as default in possibly a system preference- so it is more specific to their library. As of now, if a library wanted to set a higher / lower ratio, they would need to manually change this each time the report is run.
+1
This would be so helpful. We use a higher ratio in order to better manage our budget. Having to change it every time (and make sure all staff know that they should be changing it) takes extra time. Maybe this could be a system preference instead of being hard coded.
Created attachment 161557 [details] [review] Bug 23208: Add system preference HoldRatioDefault
Created attachment 161558 [details] [review] Bug 23208: Add ability to set a default hold ratio value To test: 1. APPLY PATCH, updatedatebase, restart_all 2. Search for the system preference 'HoldRatioDefault'. 3. It should be set to 3. Change the value to something else. 4. Load the report at 'circ/reserveratios.pl'. Circulation > Hold ratios 5. The default value should be the value you set in the new system preference. 6. Run the report with the default value and make sure it works. 7. Change the value and run the report. The new value should be retained. 8. Leave the page and come back. Again the default value from the new system preference should be set.
Created attachment 161559 [details] [review] Bug 23208: perltidy
It is important to note that if you are testing this with k-t-d then SQL strict mode needs to be turned off in the koha-conf.xml file by making sure the this line is set like so: <strict_sql_modes>0</strict_sql_modes>
Created attachment 161729 [details] [review] Bug 23208: Add system preference HoldRatioDefault Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Created attachment 161730 [details] [review] Bug 23208: Add ability to set a default hold ratio value To test: 1. APPLY PATCH, updatedatebase, restart_all 2. Search for the system preference 'HoldRatioDefault'. 3. It should be set to 3. Change the value to something else. 4. Load the report at 'circ/reserveratios.pl'. Circulation > Hold ratios 5. The default value should be the value you set in the new system preference. 6. Run the report with the default value and make sure it works. 7. Change the value and run the report. The new value should be retained. 8. Leave the page and come back. Again the default value from the new system preference should be set. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Created attachment 161731 [details] [review] Bug 23208: perltidy Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Created attachment 161855 [details] [review] Bug 23208: Add system preference HoldRatioDefault Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Created attachment 161856 [details] [review] Bug 23208: Add ability to set a default hold ratio value To test: 1. APPLY PATCH, updatedatebase, restart_all 2. Search for the system preference 'HoldRatioDefault'. 3. It should be set to 3. Change the value to something else. 4. Load the report at 'circ/reserveratios.pl'. Circulation > Hold ratios 5. The default value should be the value you set in the new system preference. 6. Run the report with the default value and make sure it works. 7. Change the value and run the report. The new value should be retained. 8. Leave the page and come back. Again the default value from the new system preference should be set. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Created attachment 161857 [details] [review] Bug 23208: perltidy Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
I squashed a typo fix into the perltidy patch. Otherwise, it looks good and passes the QA checks. This is a nice addition!
The DB update was missing the "say". Please keep an eye on these :)
Pushed for 24.05! Well done everyone, thank you!
Not backported to 23.11.x