I think this is only a string bug, but I'd like a developer to make sure nothing happens behind the scenes. When importing records and looking for duplicate records using record matching rules, there is an option if NO match is found to "ignore incoming record (its items may still be processed)". This doesn't make any sense. Where would the items go if there is no match? To reproduce : 1) Go to tools > Stage MARC for import 2) Browse and choose a file and click on Upload file 3) Go to the Look for existing records in catalog? section 4) Open the drop down for Action if no match is found 5) Note that one option says Ignore incoming record (its items may still be processed) This option should only say Ignore incoming record.
Created attachment 98774 [details] [review] Attachment to Bug 23236 - Remove 'its items may still be processed' in action if no match is found Bug 23236 - Remove 'its items may still be processed' in action if no match is found When importing records and looking for duplicate records using record matching rules, there is an option if NO match is found to "ignore incoming record (its items may still be processed)". This doesn't make any sense. Where would the items go if there is no match? To test: 1) Go to Tools > Stage MARC for import 2) Browse and choose a file with at least one record that is not already in your catalog and click on Upload file 3) Fill out the first section with the appropriate information 4) In the Look for existing records in catalog? section, choose a record matching rule 5) In the Action if no match is found drop-down menu, choose Ignore incoming record (its items may still be processed) 6) Click on Stage for import 7) Click on Manage staged records 8) Click Import this batch in the catalog 9) In the table, the record status should say Ignore 10) Apply patch 11) Redo steps 1-9, notice the option Ignore incoming records does not mention items 12) Make sure the tool still works and still ignores the record
Created attachment 98776 [details] test bib record I attached a bib record (bibliographic, encoding UTF-8, format MARC) that you can try to import. It has an ISBN and unless you have obscure Quebec authors in your catalog, you shouldn't already have it :)
Created attachment 100682 [details] [review] Bug 23236 - Remove 'its items may still be processed' in action if no match is found Signed-off-by: Devinim <kohadevinim@devinim.com.tr>
Created attachment 100887 [details] [review] Bug 23236: Remove 'its items may still be processed' in action if no match is found When importing records and looking for duplicate records using record matching rules, there is an option if NO match is found to "ignore incoming record (its items may still be processed)". This doesn't make any sense. Where would the items go if there is no match? To test: 1) Go to Tools > Stage MARC for import 2) Browse and choose a file with at least one record that is not already in your catalog and click on Upload file 3) Fill out the first section with the appropriate information 4) In the Look for existing records in catalog? section, choose a record matching rule 5) In the Action if no match is found drop-down menu, choose Ignore incoming record (its items may still be processed) 6) Click on Stage for import 7) Click on Manage staged records 8) Click Import this batch in the catalog 9) In the table, the record status should say Ignore 10) Apply patch 11) Redo steps 1-9, notice the option Ignore incoming records does not mention items 12) Make sure the tool still works and still ignores the record Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x for 19.11.05
backported to 19.05.x for 19.05.10
Minor patch will not be backported to 18.11.x series