---- Reported by rch@liblime.com 2008-07-08 16:14:46 ---- Not a good button to click accidentally. A javascript confirm should be present here. --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:49 UTC --- This bug was previously known as _bug_ 2324 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2324 Actual time not defined. Setting to 0.0 The original reporter of this bug does not have an account here. Reassigning to the person who moved it here: chris@bigballofwax.co.nz. Previous reporter was rch@liblime.com.
I'd like to see that, also for cleaning import batches.
Created attachment 49616 [details] [review] Bug 2324: Adding confirm dialog when undoing import To test: 1) Go to Tools -> Staged MARC Management 2) Click on a batch to see details 3) If not already imported, then import, otherwise you should already see the button to undo import into catalog. 4) Click this button. Confirm you are asked to confirm. Confirm clicking Cancel will cancel the undo. Confirm clicking OK will continue with the undo. Sponsored-by: Catalyst IT
Comment on attachment 49616 [details] [review] Bug 2324: Adding confirm dialog when undoing import Review of attachment 49616 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt @@ +364,4 @@ > <input type="hidden" name="runinbackground" value="" /> > <input type="hidden" name="completedJobID" value="" /> > <input type="hidden" name="import_batch_id" value="[% import_batch_id %]" /> > + <fieldset class="action"><input type="submit" class="button" name="mainformsubmit" value="Undo import into catalog" onclick="return confirm(MSG_CONFIRM_UNDO_IMPORT); return submitBackgroundJob(this.form);" /></fieldset> I don't think you want a double return. I think you want a &&.
Created attachment 49717 [details] [review] Bug 2324: Adding confirm dialog when undoing import EDIT: Comment 3 To test: 1) Go to Tools -> Staged MARC Management 2) Click on a batch to see details 3) If not already imported, then import, otherwise you should already see the button to undo import into catalog. 4) Click this button. Confirm you are asked to confirm. Confirm clicking Cancel will cancel the undo. Confirm clicking OK will continue with the undo. Sponsored-by: Catalyst IT
Created attachment 49938 [details] [review] Bug 2324: Adding confirm dialog when undoing import EDIT: Comment 3 To test: 1) Go to Tools -> Staged MARC Management 2) Click on a batch to see details 3) If not already imported, then import, otherwise you should already see the button to undo import into catalog. 4) Click this button. Confirm you are asked to confirm. Confirm clicking Cancel will cancel the undo. Confirm clicking OK will continue with the undo. Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 49958 [details] [review] Bug 2324: Adding confirm dialog when undoing import EDIT: Comment 3 To test: 1) Go to Tools -> Staged MARC Management 2) Click on a batch to see details 3) If not already imported, then import, otherwise you should already see the button to undo import into catalog. 4) Click this button. Confirm you are asked to confirm. Confirm clicking Cancel will cancel the undo. Confirm clicking OK will continue with the undo. Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Should be in the May 2016 Release. Thanks!