Using koha-create with latest master generates a broken mysql password in koha-conf.xml, like this > <pass>B6_uW%vW"__DB_PASS__`1l(Gm</pass> The problem does not appear when I revert the changes from bug 23090. This will make every new instance unusable. It's in the nightly, that means new devboxes will be broken too I guess.
What was the koha-create command used to generate that?! Because: sudo koha-create --create-db {instance name} generally is working for me.
Created attachment 91250 [details] [review] Bug 23250: Just use an @ in the password Rather than try to use -y and symbols, since older versions of pwgen don't have the -y, Purposefully just shorten the generated password to 15 characters and put @ on the end. This avoids nasty shell globbing, fixes the MySQL requiring a symbol by default in the newer versions. While @ at the end is less secure, the password portion providing security is still 15 characters long. Before patch, password should have potentially multiple ugly symbols in it. After patch, when creating an instance, the password will have an @ at the end of it.
Created attachment 91251 [details] [review] Bug 23250: Just use an @ in the password Rather than try to use -y and symbols, since older versions of pwgen don't have the -y, Purposefully just shorten the generated password to 15 characters and put @ on the end. This avoids nasty shell globbing, fixes the MySQL requiring a symbol by default in the newer versions. While @ at the end is less secure, the password portion providing security is still 15 characters long. Before patch, password should have potentially multiple ugly symbols in it. After patch, when creating an instance, the password will have an @ at the end of it.
Created attachment 91284 [details] [review] Bug 23250: Just use an @ in the password Rather than try to use -y and symbols, since older versions of pwgen don't have the -y, Purposefully just shorten the generated password to 15 characters and put @ on the end. This avoids nasty shell globbing, fixes the MySQL requiring a symbol by default in the newer versions. While @ at the end is less secure, the password portion providing security is still 15 characters long. Before patch, password should have potentially multiple ugly symbols in it. After patch, when creating an instance, the password will have an @ at the end of it. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Simple patch that works well. Thanks Mark, Going straight for PQA
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.02
backported to 18.11.x for 18.11.08
Ok, sorry, actually it was already without special chars prior to bug 23090!