Should be an easy fix to remove the http://, since the OPACBaseUrl is supposed to have the protocol in it. Need to create an atomic update (fix during upgrade) AND fix installer/data/mysql/fr-CA/obligatoire/sample_notices.sql (fix on fresh install) TEST PLAN ---------- 1) install fresh for fr-CA language 2) OPAC_REG_VERIFY letter should have http:// in it. 3) apply patch 4) restart all 5) run database upgrade 6) OPAC_REG_VERIFY letter should not have http:// in it. 7) reset all 8) OPAC_REG_VERIFY letter should not have http:// in it. 9) run qa test tools
Created attachment 95616 [details] [review] Bug 23256: Remove the http:// prefix before OPACBaseURL in OPAC_REG_VERIFY The title explained everything, compare with installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql and other notices. It's certainly due to the fact that fr-CA took time to be integrated and the change happened in the meanwhile
Created attachment 95767 [details] [review] Bug 23256: Remove the http:// prefix before OPACBaseURL in OPAC_REG_VERIFY The title explained everything, compare with installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql and other notices. It's certainly due to the fact that fr-CA took time to be integrated and the change happened in the meanwhile Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Trivial fix, passing QA.
Nice work! Pushed to master for 19.11.00