The staff client's global CSS file imports a CSS file called "reset-fonts-grids.css," a set of defaults and grid definitions from the YUI library. We can remove this now that we have Bootstrap grids on all staff client pages. Some of our CSS will require some minor updates.
Created attachment 91334 [details] [review] Bug 23259: Remove reset-fonts-grids.css This patch removes the CSS file reset-fonts-grids.css which was required when the staff client templates used YUI grids. Now that all staff client templates have been converted to Bootstrap grid markup the file can be deleted. Because the YUI CSS also did set some baseline properties for different tags the global SCSS file is modified in this patch in order to keep things looking consistent. Most of these updates change font-size declarations to preserve the previous appearance. Some styling has been added to (non Bootstrap-classed) <input> and <button> tags in order to keep button style consistent. Removed from staff-global.scss: YUI-specific CSS which has been made obsolete by the template conversions. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. Browse through various pages of thes staff client to confirm that the changes work well.
Created attachment 91336 [details] [review] Bug 23259: Remove reset-fonts-grids.css This patch removes the CSS file reset-fonts-grids.css which was required when the staff client templates used YUI grids. Now that all staff client templates have been converted to Bootstrap grid markup the file can be deleted. Because the YUI CSS also did set some baseline properties for different tags the global SCSS file is modified in this patch in order to keep things looking consistent. Most of these updates change font-size declarations to preserve the previous appearance. Some styling has been added to (non Bootstrap-classed) <input> and <button> tags in order to keep button style consistent. Removed from staff-global.scss: YUI-specific CSS which has been made obsolete by the template conversions. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. Browse through various pages of thes staff client to confirm that the changes work well. Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com>
Created attachment 91388 [details] [review] Bug 23259: Remove reset-fonts-grids.css This patch removes the CSS file reset-fonts-grids.css which was required when the staff client templates used YUI grids. Now that all staff client templates have been converted to Bootstrap grid markup the file can be deleted. Because the YUI CSS also did set some baseline properties for different tags the global SCSS file is modified in this patch in order to keep things looking consistent. Most of these updates change font-size declarations to preserve the previous appearance. Some styling has been added to (non Bootstrap-classed) <input> and <button> tags in order to keep button style consistent. Removed from staff-global.scss: YUI-specific CSS which has been made obsolete by the template conversions. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Clear your browser cache if necessary. Browse through various pages of thes staff client to confirm that the changes work well. Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00
Enhancement not pushed to 19.05.x