Simple fix: opac-bottom.inc should do the work not opac-shelves itself.
Created attachment 91290 [details] [review] Bug 23266: Add to cart fires twice on shelf page Remove some duplicate functionality between opac-bottom and opac-shelves. Test plan: [1] Before this patch, add to cart from a shelf page. Observe that the basket count is incremented with 2. [2] After this patch, it should be incremented with 1. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 91321 [details] [review] Bug 23266: Add to cart fires twice on shelf page Remove some duplicate functionality between opac-bottom and opac-shelves. Test plan: [1] Before this patch, add to cart from a shelf page. Observe that the basket count is incremented with 2. [2] After this patch, it should be incremented with 1. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Simple fix that clarifies the code and corrects the issue. Signing off.
Created attachment 91391 [details] [review] Bug 23266: Add to cart fires twice on shelf page Remove some duplicate functionality between opac-bottom and opac-shelves. Test plan: [1] Before this patch, add to cart from a shelf page. Observe that the basket count is incremented with 2. [2] After this patch, it should be incremented with 1. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.03
backported to 18.11.x for 18.11.09