To Test: - go to overdues.pl - construct a search limiting by date due and library - note number of overdues in results - click "Download file of displayed overdues" - note that downloaded file contains all overdues, not just those in your search
The URLs of the download link are quite different (browser used was Microsoft Edge, but the filtering loss was observed with other browsers). The URL in 18.11.04 (our version now): https://ual-staff.koha-ptfs.co.uk/cgi-bin/koha/circ/overdue.pl?op=csv&dateduefrom%3D%26datedueto%3D%26borname%3D%26borcat%3D%26borflag%3D%26patron_attr_filter_COURSE%3D%26patron_attr_filter_COURSEDES%3D%26patron_attr_filter_LIBNO%3D%26patron_attr_filter_STUDENTID%3D%26itemtype%3D%26homebranch%3D%26holdingbranch%3D%26branch%3DLCF The URL in 17.04 (our previous version, with the branch filter set to London College of Fashion (LCF): https://ualtest-staff.koha-ptfs.co.uk/cgi-bin/koha/circ/overdue.pl?op=csv&dateduefrom=;datedueto=;borname=;borcat=;borflag=;patron_attr_filter_COURSE=;patron_attr_filter_COURSEDES=;patron_attr_filter_LIBNO=;patron_attr_filter_STUDENTID=;itemtype=;homebranch=;holdingbranch=;branch=LCF
Confirmed on master. This looks like it could be a problem with the construction of the URL/use of filters.
Created attachment 92365 [details] [review] Bug 23273: Fix CSV export for overdues We should construct the URI parameters string manually to avoid filtering problems. We cannot send the full query_string to the template and expect that the string will be escaped correctly. Test plan: - go to overdues.pl - construct a search limiting by date due and library - note number of overdues in results - click "Download file of displayed overdues" => note that downloaded file contains just those in your search
Created attachment 92367 [details] [review] Bug 23281: Cleanup Koha::Patron::Attribute::Types->search Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
(In reply to Owen Leonard from comment #4) > Bug 23281: Cleanup Koha::Patron::Attribute::Types->search I blame git-bz!
Created attachment 92368 [details] [review] Bug 23273: Fix CSV export for overdues We should construct the URI parameters string manually to avoid filtering problems. We cannot send the full query_string to the template and expect that the string will be escaped correctly. Test plan: - go to overdues.pl - construct a search limiting by date due and library - note number of overdues in results - click "Download file of displayed overdues" => note that downloaded file contains just those in your search Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 92372 [details] [review] Bug 23273: Fix CSV export for overdues We should construct the URI parameters string manually to avoid filtering problems. We cannot send the full query_string to the template and expect that the string will be escaped correctly. Test plan: - go to overdues.pl - construct a search limiting by date due and library - note number of overdues in results - click "Download file of displayed overdues" => note that downloaded file contains just those in your search Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
We are missing a filter here, should be an easy fix, but was not sure which one to use here: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt FAIL filters missing_filter at line 39 ( [% url_params = BLOCK %][% url_params %]&[% var | uri %]=[% filters.$var | uri %][% END %]) Leaving PQA for now.
Nice work! Pushed to master for 19.11.00
(In reply to Katrin Fischer from comment #8) > We are missing a filter here, should be an easy fix, but was not sure which > one to use here: > > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt > FAIL filters > missing_filter at line 39 ( [% url_params = BLOCK %][% > url_params %]&[% var | uri %]=[% filters.$var | uri %][% END %]) > > Leaving PQA for now. Martin, you added: - [% url_params = BLOCK %][% url_params %]&[% var | uri %]=[% filters.$var | uri %][% END %] + [% url_params = BLOCK %][% url_params | uri %]&[% var | uri %]=[% filters.$var | uri %][% END %] It feel wrong, it should be $raw, otherwise it will be double encoded.
Also, there was a debug statement: +use Data::Printer colored => 1; warn p $filters;
Created attachment 92517 [details] [review] Bug 23273: Remove debug statement
Created attachment 92527 [details] [review] Bug 23273: Remove debug statement Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Moving into PQA queue for better visibility.
Pushed to 19.05.x for 19.05.04
Sorry I went to fast on backporting this. A patch is missing in master and i found an issue. I revert for now from 19.05.x
Followup pushed and filters corrected.
backported to 18.11.x for 18.11.10