I would like to reindent cataloging/addbooks.tt: Remove tabs, correct indentation, add some comments to clarify the structure.
Created attachment 91594 [details] [review] Bug 23339: Reindent addbooks.tt This patch reindents cataloguing/addbooks.tt to use four spaces, following coding guidelines. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but you should look into your own heart for the right solution. Go to Cataloging. Test that the initial page and search results view look correct and work correctly.
Created attachment 91595 [details] [review] Bug 23339: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also removes the obsolete "type" attribute from the <script> tag. This patch should have no effect on the interface or functionality.
Created attachment 91669 [details] [review] Bug 23339: Reindent addbooks.tt This patch reindents cataloguing/addbooks.tt to use four spaces, following coding guidelines. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but you should look into your own heart for the right solution. Go to Cataloging. Test that the initial page and search results view look correct and work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 91670 [details] [review] Bug 23339: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also removes the obsolete "type" attribute from the <script> tag. This patch should have no effect on the interface or functionality. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 91867 [details] [review] Bug 23339: Reindent addbooks.tt This patch reindents cataloguing/addbooks.tt to use four spaces, following coding guidelines. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but you should look into your own heart for the right solution. Go to Cataloging. Test that the initial page and search results view look correct and work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 91868 [details] [review] Bug 23339: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also removes the obsolete "type" attribute from the <script> tag. This patch should have no effect on the interface or functionality. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 92013 [details] [review] Bug 23339: Reindent addbooks.tt This patch reindents cataloguing/addbooks.tt to use four spaces, following coding guidelines. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but you should look into your own heart for the right solution. Go to Cataloging. Test that the initial page and search results view look correct and work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 92014 [details] [review] Bug 23339: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also removes the obsolete "type" attribute from the <script> tag. This patch should have no effect on the interface or functionality. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work! Pushed to master for 19.11.00
Enhancement not pushed to 19.05.x (Does not apply on 19.05.x)