C4::XSLT::XSLTParse4Display calls buildKohaItemsNamespace() for all displays For IntranetDetails and OPACDetails there is no item processing. Removing this call can save us time
Created attachment 91900 [details] [review] Bug 23407: Don't process items for XSLT on details pages To test: 1 - Add 1000 items to a record Go to biblio Edit items Add multiple copies of this item Add 1000 and confirm Wait.. 2 - Load the record in staff client and OPAC, note how long it takes Press F12 in browser to open the console use the Network tab of the console note th eload time refresh a few times to see average time 3 - Apply patch 4 - Restart all the things 5 - Reload the record in staff and opac 6 - Note decresed time 7 - Verify nothing on the page has changed QA can grep the standard XSLT files for details pages for 'item' to note occurences do not use items information
Created attachment 91916 [details] [review] Bug 23407: Don't process items for staff results either We also don't use the items here, same test plan but on staff cleint results, should see no change
This worked as advertised but I got this warning from the qa tool: FAIL C4/XSLT.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s).
Created attachment 92045 [details] [review] Bug 23407: Don't process items for XSLT on details pages To test: 1 - Add 1000 items to a record Go to biblio Edit items Add multiple copies of this item Add 1000 and confirm Wait.. 2 - Load the record in staff client and OPAC, note how long it takes Press F12 in browser to open the console use the Network tab of the console note the load time refresh a few times to see average time 3 - Apply patch 4 - Restart all the things 5 - Reload the record in staff and opac 6 - Note decresed time 7 - Verify nothing on the page has changed QA can grep the standard XSLT files for details pages for 'item' to note occurences do not use items information
Created attachment 97850 [details] [review] Bug 23407: Don't process items for XSLT on details pages To test: 1 - Add 1000 items to a record Go to biblio Edit items Add multiple copies of this item Add 1000 and confirm Wait.. 2 - Load the record in staff client and OPAC, note how long it takes Press F12 in browser to open the console use the Network tab of the console note the load time refresh a few times to see average time 3 - Apply patch 4 - Restart all the things 5 - Reload the record in staff and opac 6 - Note decresed time 7 - Verify nothing on the page has changed QA can grep the standard XSLT files for details pages for 'item' to note occurences do not use items information Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
QA: Looking here > QA can grep the standard XSLT files for details pages for 'item' to note > occurences do not use items information intranetResults xmlns:items="http://www.koha-community.org/items" exclude-result-prefixes="marc items str"> <xsl:key name="item-by-status" match="items:item" use="items:status"/> <xsl:key name="item-by-status-and-branch" match="items:item" use="concat(items:status, ' ', items:homebranch)"/> <xsl:variable name="hidelostitems" select="marc:sysprefs/marc:syspref[@name='hidelostitems']"/> still a few lines in intranetDetails too Removed in a follow-up
Created attachment 97854 [details] [review] Bug 23407: Don't process items for XSLT on details pages To test: 1 - Add 1000 items to a record Go to biblio Edit items Add multiple copies of this item Add 1000 and confirm Wait.. 2 - Load the record in staff client and OPAC, note how long it takes Press F12 in browser to open the console use the Network tab of the console note the load time refresh a few times to see average time 3 - Apply patch 4 - Restart all the things 5 - Reload the record in staff and opac 6 - Note decresed time 7 - Verify nothing on the page has changed QA can grep the standard XSLT files for details pages for 'item' to note occurences do not use items information Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 97855 [details] [review] Bug 23407: (QA follow-up) Remove some XSLT item leftovers Test plan: Check intranet results and detail page. Check opac detail. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 97856 [details] [review] Bug 23407: (QA follow-up) Same change for UNIMARC XSLT Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.03
backported to 19.05.x for 19.05.08
Enhancement will not be backported to 18.11.x series.