Bug 23418 - Patron modification controls
Summary: Patron modification controls
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-02 14:54 UTC by Christopher Brannon
Modified: 2019-08-02 17:37 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Brannon 2019-08-02 14:54:22 UTC
The radio buttons are unusual in members-update.pl.  I would like to suggest that the radio buttons are replaced with buttons below the changes:
* Approve
* Deny
* Cancel (instead of ignore - which is confusing, or just eliminate altogether)
Comment 1 Owen Leonard 2019-08-02 15:33:09 UTC
> that the radio buttons are replaced with buttons

The controls are radio buttons because the interface was designed to let the user confirm or deny the changes for multiple patrons at once. A regular submit button would reload the page after each patron.

> * Cancel (instead of ignore - which is confusing, or just eliminate
> altogether)

Ignore is important because the person reviewing the list of changes may not want to address it for some reason. "Cancel" implies that the modification request would disappear.

Eliminating it might be possible if the radio buttons were converted to submit buttons, but I don't think that's the right choice.
Comment 2 Christopher Brannon 2019-08-02 17:37:31 UTC
(In reply to Owen Leonard from comment #1)
> > that the radio buttons are replaced with buttons
> 
> The controls are radio buttons because the interface was designed to let the
> user confirm or deny the changes for multiple patrons at once. A regular
> submit button would reload the page after each patron.
> 
> > * Cancel (instead of ignore - which is confusing, or just eliminate
> > altogether)
> 
> Ignore is important because the person reviewing the list of changes may not
> want to address it for some reason. "Cancel" implies that the modification
> request would disappear.
> 
> Eliminating it might be possible if the radio buttons were converted to
> submit buttons, but I don't think that's the right choice.

I understand.  The accordion interface is a little unusual though, and not typical for other bulk modifications that I am aware of.  It is also strange to use this method without a confirmation of all the changes being made.  But that is beside the point.