If one cancels a transfer that has been initiated via StockRotation, then the next call to the stockrotation cronjob will fail due to a 'die' line when said transfer can no longer be found.
Created attachment 110591 [details] [review] Bug 23432: Replace 'die' with 'warn' This patch simply replaced the die statement with a warn such that the cron script may continue to rotate other items even if this item cannot be properly rotated due to corrupt data.
The patch here simply replaces the die with a warn. It does not attempt to fix the original cause of the data corruption that can take place... we attempt to resolve that in the transfers re-write tree where we significantly clean up how the transfers processes all interact.
Created attachment 112405 [details] [review] Bug 23432: Replace 'die' with 'warn' This patch simply replaced the die statement with a warn such that the cron script may continue to rotate other items even if this item cannot be properly rotated due to corrupt data. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 112424 [details] [review] Bug 23432: Replace 'die' with 'warn' This patch simply replaced the die statement with a warn such that the cron script may continue to rotate other items even if this item cannot be properly rotated due to corrupt data. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 112425 [details] [review] Bug 23432: (QA follow-up) Add a unit test prove -v t/db_dependent/StockRotationItems.t Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.06
missing dependencies, not backported to 19.11.x