I would like to reindent reserve/request.tt: Remove tabs, correct indentation, add some comments to clarify the structure.
Created attachment 92242 [details] [review] Bug 23458: Clean up holds template in the staff client This patch reindents reserve/request.tt to use four spaces and to eliminate tabs, following coding guidelines. Trailing white space has been removed. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm no diffctator. Test the process of placing a hold in the staff client: A single hold, multiple holds, etc. Everything should work correctly.
Created attachment 92243 [details] [review] Bug 23458: (follow-up) Add comments to markup This patch adds a few comments to the markup in order to highlight the structure of the page.
Created attachment 92295 [details] [review] Bug 23458: Clean up holds template in the staff client This patch reindents reserve/request.tt to use four spaces and to eliminate tabs, following coding guidelines. Trailing white space has been removed. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm no diffctator. Test the process of placing a hold in the staff client: A single hold, multiple holds, etc. Everything should work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 92296 [details] [review] Bug 23458: (follow-up) Add comments to markup This patch adds a few comments to the markup in order to highlight the structure of the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 92331 [details] [review] Bug 23458: Clean up holds template in the staff client This patch reindents reserve/request.tt to use four spaces and to eliminate tabs, following coding guidelines. Trailing white space has been removed. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm no diffctator. Test the process of placing a hold in the staff client: A single hold, multiple holds, etc. Everything should work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 92332 [details] [review] Bug 23458: (follow-up) Add comments to markup This patch adds a few comments to the markup in order to highlight the structure of the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00
Enhancement not pushed to 19.05.x