Created attachment 92249 [details] Screenshot of the duplicated screen At 18.11, if the BlockExpiredPatronOpacActions system preference is set to block, when an expired patron attempts to place a hold in the OPAC, the screen duplicates with a cookies error in the middle of the screen. See screenshot attached. I can't reproduce this at 17.11. To reproduce at 18.11. 1) Ensure that BlockExpiredPatronOpacActions is set to Block, and ensure that this is not be overridden by the Patron Category policy. 2) Log into the OPAC as an expired user. 3) Search for an item to hold 4) Click Place Hold Setting the BlockExpiredPatronOpacActions system preference means the hold gets placed normally. I also notice that the lower half of the screen (i.e. the duplicated portion) ignores any jQuery configuration.
Confirmed on master too.
Created attachment 92271 [details] Screenshot of the duplicated screen Re-posting the screenshot as a JPEG
OPAC bug, major... giving it another nudge.
Created attachment 95093 [details] [review] Bug 23467: Exit after output_html - opac-reserve.pl To avoid double screen There are several ways to recreate the issue, the easiest is: /cgi-bin/koha/opac-reserve.pl?biblionumber= You should see "ERROR: No record id specified."
Created attachment 95097 [details] [review] Bug 23467: Exit after output_html - opac-reserve.pl To avoid double screen There are several ways to recreate the issue, the easiest is: /cgi-bin/koha/opac-reserve.pl?biblionumber= You should see "ERROR: No record id specified." Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nudging it further. I tested both, the way Jonathan suggested with the missing parameter and the original problem case with the holds.
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.05