When writing of an individual fine or fee, the description column shows the title of the patron (mr, mrs, borrowers.title). Could this be a variable confusion? (Record title vs. patron title?) So far confirmed in latest 18.11.
Confirmed on master now as well. To test: - Make sure that in the account you use a saluation is set (Mr Mrs...) - Create a manual fine - Pay or Writeoff the fine using the buttons next to the fine (not at the bottom) - Look at the description shown before saving
(In reply to Katrin Fischer from comment #1) > Confirmed on master now as well. > > To test: > - Make sure that in the account you use a saluation is set (Mr Mrs...) > - Create a manual fine > - Pay or Writeoff the fine using the buttons next to the fine (not at the > bottom) > - Look at the description shown before saving It only happens for writeoff.
Created attachment 94986 [details] [review] Bug 23483: Show the description, not the patron's title when writing off an individual fine/fee When writing off an individual fine, the description shown was the patron's title, instead of the fine description. Fixing it by changing it to the same template variable used for paying individuals so they match up. To test: - Pick a patron and make sure salutation is set (Mr, Mrs, ...) - Create a manual fine - For the fine, compare the description shown when using the Writeoff and Pay buttons next to the fine - Verify the display is different and writeoff displays the salutation - Apply patch - Repeat, descriptions now should match up
Created attachment 94992 [details] [review] Bug 23483: Show the description, not the patron's title when writing off an individual fine/fee When writing off an individual fine, the description shown was the patron's title, instead of the fine description. Fixing it by changing it to the same template variable used for paying individuals so they match up. To test: - Pick a patron and make sure salutation is set (Mr, Mrs, ...) - Create a manual fine - For the fine, compare the description shown when using the Writeoff and Pay buttons next to the fine - Verify the display is different and writeoff displays the salutation - Apply patch - Repeat, descriptions now should match up Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Thank you Severine!
Created attachment 95116 [details] [review] Bug 23483: Show the description, not the patron's title when writing off an individual fine/fee When writing off an individual fine, the description shown was the patron's title, instead of the fine description. Fixing it by changing it to the same template variable used for paying individuals so they match up. To test: - Pick a patron and make sure salutation is set (Mr, Mrs, ...) - Create a manual fine - For the fine, compare the description shown when using the Writeoff and Pay buttons next to the fine - Verify the display is different and writeoff displays the salutation - Apply patch - Repeat, descriptions now should match up Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial patch works as expected.. passing qa
Nice work! Pushed to master for 19.11.00
We found this in 18.11 - please backport! :)
backported to 19.05.x for 19.05.06
Backported to 18.11.x for 18.11.12
Thx Lucas and Hayley :)