I would like to reindent tools/letter.tt: Correct indentation, replace tabs with spaces, and add some comments to clarify the structure.
Created attachment 92509 [details] [review] Bug 23512: Reindent notices and slips page (letter.tt) This patch re-indents the template for notices and slips. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, go to Tools -> Notices & slips. Test every aspect of the notice creation and edit process. At each step the page should work correctly.
Created attachment 92510 [details] [review] Bug 23512: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality.
Created attachment 92529 [details] [review] Bug 23512: Reindent notices and slips page (letter.tt) This patch re-indents the template for notices and slips. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, go to Tools -> Notices & slips. Test every aspect of the notice creation and edit process. At each step the page should work correctly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 92530 [details] [review] Bug 23512: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 92547 [details] [review] Bug 23512: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 92548 [details] [review] Bug 23512: Reindent notices and slips page (letter.tt) This patch re-indents the template for notices and slips. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, go to Tools -> Notices & slips. Test every aspect of the notice creation and edit process. At each step the page should work correctly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 92549 [details] [review] Bug 23512: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
So pleased to see lots of templates getting this treatment.. nice to have clean nicely indented files to work on.
Nice work! Pushed to master for 19.11.00
Enhancement not pushed to 19.05.x