In staff interface, ISBD view always uses view policy of ACQ framework. This comes from a change from commit : Bug 19289: Use the ACQ framework to display bibliographic details @@ -97,7 +97,7 @@ my $record_processor = Koha::RecordProcessor->new({ filters => 'ViewPolicy', options => { interface => 'intranet', - frameworkcode => $framework + frameworkcode => 'ACQ' }, Is this a mistake ?
Yes, I think this should have no effect on the ISBD views in ACQ and/or catalog pages, it seems counter-intuitive.
Created attachment 94042 [details] [review] Bug 23525: (bug 19289 follow-up) Use biblio's framework not ACQ This patch restores the behavior prior to commit 84ce1fb5921cdddf2368f0c330dede0f602742d0 Bug 19289: Use the ACQ framework to display bibliographic details Test plan is hard to provide for such a simple and obvious change. I would recommend you to read the previous commit and confirm that the change did not make sense.
Created attachment 94102 [details] [review] Bug 23525: (bug 19289 follow-up) Use biblio's framework not ACQ This patch restores the behavior prior to commit 84ce1fb5921cdddf2368f0c330dede0f602742d0 Bug 19289: Use the ACQ framework to display bibliographic details Test plan is hard to provide for such a simple and obvious change. I would recommend you to read the previous commit and confirm that the change did not make sense. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 94751 [details] [review] Bug 23525: (bug 19289 follow-up) Use biblio's framework not ACQ This patch restores the behavior prior to commit 84ce1fb5921cdddf2368f0c330dede0f602742d0 Bug 19289: Use the ACQ framework to display bibliographic details Test plan is hard to provide for such a simple and obvious change. I would recommend you to read the previous commit and confirm that the change did not make sense. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work! Pushed to master for 19.11.00