There are three places in the patron entry template which use the same logic for displaying the patron category. These can be converted into a single re-usable block.
I'm repurposing this bug because further investigation shows that the repeated section of markup is in fact obsolete. I will submit a patch to remove the obsolete markup.
Created attachment 92587 [details] [review] Bug 23536: Remove obsolete category markup from patron entry This patch removes some obsolete markup from the patron entry template (memberentrygen.tt). The old markup was necessary in a long-gone version of Koha where it was possible to add patrons using built-in categories instead of defining your own. To test, apply the patch and test the process of adding or editing patrons. You should see the patron category displayed correctly in the page title, breadcrumbs, and main heading.
Created attachment 92663 [details] [review] Bug 23536: Remove obsolete category markup from patron entry This patch removes some obsolete markup from the patron entry template (memberentrygen.tt). The old markup was necessary in a long-gone version of Koha where it was possible to add patrons using built-in categories instead of defining your own. To test, apply the patch and test the process of adding or editing patrons. You should see the patron category displayed correctly in the page title, breadcrumbs, and main heading. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Blocked by bug 23533 and bug 23534 atm. Please switch back once this has been resolved!
Created attachment 99769 [details] [review] Bug 23536: Remove obsolete category markup from patron entry This patch removes some obsolete markup from the patron entry template (memberentrygen.tt). The old markup was necessary in a long-gone version of Koha where it was possible to add patrons using built-in categories instead of defining your own. To test, apply the patch and test the process of adding or editing patrons. You should see the patron category displayed correctly in the page title, breadcrumbs, and main heading. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 99827 [details] [review] Bug 23536: Remove obsolete category markup from patron entry This patch removes some obsolete markup from the patron entry template (memberentrygen.tt). The old markup was necessary in a long-gone version of Koha where it was possible to add patrons using built-in categories instead of defining your own. To test, apply the patch and test the process of adding or editing patrons. You should see the patron category displayed correctly in the page title, breadcrumbs, and main heading. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
Not sure this is correct, here we wanted to make the "category_type" translatable. It is not possible to create new category types.
(In reply to Jonathan Druart from comment #8) > Not sure this is correct, here we wanted to make the "category_type" > translatable. It is not possible to create new category types. Hum weird, not from this patch, neither from previous bug that impacts it (bug 15407). So either it's super old, or it never worked as intended.
not backported to 19.11.x due to dependencies