Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator Some items from overdrive, such as magazines, don't have a primaryCreator in their object. When Koha gets a result like this, the overdrive search won't show any results after the first to have this condition, because it's trying to push an undefined property.
Created attachment 92586 [details] [review] Bug 23537: Overdrive won't show complete results at all times To test: On an overdrive enabled OPAC (tough sell, I know) Do a search for something you know has magazines, the collection I was looking at had "knit" as one Without this patch, the results will show "(many) items found in overdrive collection" but only show a small number of them. With the patch, the number of results should match the number shown/paginated. A site that has this fix applied, is https://tracy.bywatersolutions.com/cgi-bin/koha/opac-overdrive-search.pl?q=knit Before this patch, the number of results was 44, but there were only 8 shown. Now we see all 44
Created attachment 92706 [details] [review] Bug 23537: Overdrive won't show complete results at all times To test: On an overdrive enabled OPAC (tough sell, I know) Do a search for something you know has magazines, the collection I was looking at had "knit" as one Without this patch, the results will show "(many) items found in overdrive collection" but only show a small number of them. With the patch, the number of results should match the number shown/paginated. A site that has this fix applied, is https://tracy.bywatersolutions.com/cgi-bin/koha/opac-overdrive-search.pl?q=knit Before this patch, the number of results was 44, but there were only 8 shown. Now we see all 44 Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 93036 [details] [review] Bug 23537: Overdrive won't show complete results at all times To test: On an overdrive enabled OPAC (tough sell, I know) Do a search for something you know has magazines, the collection I was looking at had "knit" as one Without this patch, the results will show "(many) items found in overdrive collection" but only show a small number of them. With the patch, the number of results should match the number shown/paginated. A site that has this fix applied, is https://tracy.bywatersolutions.com/cgi-bin/koha/opac-overdrive-search.pl?q=knit Before this patch, the number of results was 44, but there were only 8 shown. Now we see all 44 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Nice work! Pushed to master for 19.11.00
One-line patch, I choose to backport to 19.05.x Pushed to 19.05.x for 19.05.04
backported to 18.11.x for 18.11.11