Account type is a varchar(16), but the authorised value filling it ( MANUAL_INVOICE type ) is a varchar(80). Account type should be increased to this size to avoid truncation of authorised values.
Created attachment 92591 [details] [review] Bug 23539: accountlines.accounttype should match authorised_values.authorised_value in size
Created attachment 92605 [details] [review] Bug 23539: accountlines.accounttype should match authorised_values.authorised_value in size Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 92614 [details] [review] Bug 23539: accountlines.accounttype should match authorised_values.authorised_value in size Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
I've been meaning to sort this one out for ages.. thanks so much for getting to it :).
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.04
(In reply to Kyle M Hall from comment #0) > Account type is a varchar(16), but the authorised value filling it ( > MANUAL_INVOICE type ) is a varchar(80). Account type should be increased to > this size to avoid truncation of authorised values. Authorised values category is call 'MANUAL_INV'
(In reply to Fridolin SOMERS from comment #7) > (In reply to Kyle M Hall from comment #0) > > Account type is a varchar(16), but the authorised value filling it ( > > MANUAL_INVOICE type ) is a varchar(80). Account type should be increased to > > this size to avoid truncation of authorised values. > > Authorised values category is call 'MANUAL_INV' Thanks for the correction Frido!