Bug 23553 - Internal server error while placing a reserve through staff interface
Summary: Internal server error while placing a reserve through staff interface
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: 18.11
Hardware: All All
: P2 major (vote)
Assignee: Arthur Suzuki
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-06 09:07 UTC by Arthur Suzuki
Modified: 2020-06-04 20:32 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 23553 : fix internal server error while placing reserve on item from pro interface (1.34 KB, patch)
2019-09-06 09:18 UTC, Arthur Suzuki
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Arthur Suzuki 2019-09-06 09:07:54 UTC
When selecting a specific item in the pro interface, got "internal server error"
Plack complains :
Can't call method "itemnumber" on unblessed reference at /home/koha/src/reserve/placerequest.pl line 94.
Comment 1 Arthur Suzuki 2019-09-06 09:18:25 UTC
Created attachment 92616 [details] [review]
Bug 23553 : fix internal server error while placing reserve on item from pro interface

test plan :
1 / try to place a reserve on a specific item from the pro interface
2 / get failure
3 / apply patch
4 / repeat 1 and verify you don't get failure + there is a new reserve on the selected item.
Comment 2 Bouzid Fergani 2019-09-13 20:18:09 UTC
Hi,
Thanks to rebase this patch for testing.

Bug 23553 - Internal server error while placing a reserve through staff interface

92616 - Bug 23553 : fix internal server error while placing reserve on item from pro interface

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 23553 : fix internal server error while placing reserve on item from pro interface
Using index info to reconstruct a base tree...
M	reserve/placerequest.pl
Falling back to patching base and 3-way merge...
Auto-merging reserve/placerequest.pl
CONFLICT (content): Merge conflict in reserve/placerequest.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 23553 : fix internal server error while placing reserve on item from pro interface
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-23553--fix-internal-server-error-while-placing-_8SBm9.patch

Bouzid.
Comment 3 Katrin Fischer 2019-09-16 05:12:27 UTC
Hi Bouzid, have you tried this on an 18.11 installation?

Arthur, is this 18.11 only or for higher versions too?
Comment 4 Arthur Suzuki 2019-09-24 10:21:04 UTC
Hi Katrin,
I've noticed the issue in 18.11 only, not in master.
Arthur
Comment 5 Katrin Fischer 2019-09-30 10:38:08 UTC
I have tested in 18.11.06, according to Arthur he has tested in 18.11.05. I think I found the fixing commit too - closing :)

http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=d617065162df47ffaf35fc192f260c702fd62602