I propose to add column configuration and export options to the authorized values administration page. The table would only have one toggle-able column, but I think the export options could be useful to libraries.
(In reply to Owen Leonard from comment #0) > The table would only have one toggle-able > column Now with a dependency on Bug 23612 I'm going to leave out the column configuration altogether and just include the export option.
Created attachment 92819 [details] [review] Bug 23611: Add export option to authorized values administration This patch changes the authorized values DataTables configuration to add export options. To test apply the patch and go to Administration -> Authorized values. Test the "Export" button and confirm that the data is exported correctly with each option.
Created attachment 92866 [details] [review] Exports nicely with all 4 options. Signing off. Bug 23611: Add export option to authorized values administration This patch changes the authorized values DataTables configuration to add export options. To test apply the patch and go to Administration -> Authorized values. Test the "Export" button and confirm that the data is exported correctly with each option. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
The patch appears to break sorting on the individual category pages (like HINGS_PF for example)
Created attachment 93501 [details] [review] Bug 23611: (follow-up) Correct ID of table The DataTable configuration wasn't working on the table showing an individual category's authorized values because of a mismatch in the table id. This patch corrects it. To test, apply the patch and view the "Authorized values" page. The initial list of categories should be displayed as a DataTable. Click through to see the values defined for any category. The resulting table of values should also be a functioning DataTable.
Hi Owen, last request (I hope) - can you please remove the action buttons from the print view and other export options?
Created attachment 93615 [details] [review] Bug 23611: (follow-up) Exclude "actions" column from export This patch adds a missing "noExport" class to ensure that the "actions" column isn't included in export and print views.
Created attachment 93616 [details] [review] Bug 23611: Add export option to authorized values administration This patch changes the authorized values DataTables configuration to add export options. To test apply the patch and go to Administration -> Authorized values. Test the "Export" button and confirm that the data is exported correctly with each option. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 93617 [details] [review] Bug 23611: (follow-up) Correct ID of table The DataTable configuration wasn't working on the table showing an individual category's authorized values because of a mismatch in the table id. This patch corrects it. To test, apply the patch and view the "Authorized values" page. The initial list of categories should be displayed as a DataTable. Click through to see the values defined for any category. The resulting table of values should also be a functioning DataTable. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 93618 [details] [review] Bug 23611: (follow-up) Exclude "actions" column from export This patch adds a missing "noExport" class to ensure that the "actions" column isn't included in export and print views. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00