The 'your charges' OPAC page display all charges (paid for or otherwise) that the user has ever had. It's also the page where, if enabled, a user can initiate an online payment. If there's is a large history of paid charges displayed then it can be cumbersome to pick out the charges owed and scroll to the bottom of the page to reach the pay now buttons. I propose we filter the table by default to just outstanding account lines and allow the full view via a button/checkbox.
Created attachment 94532 [details] [review] Bug 23633: Hide paid transactions by default on the OPAC This patch adds filtering on paid for type transactions to the OPAC accounts page. The filtering is enabled by default but may be toggled to show historical transactions.
Test plan, 1) Select a patron with a number of paid for and not paid for transactions over a period of time. 2) Navigate to their 'accounts' page in the OPAC 3) Note that paid for transactions are filtered on page load 4) Click the 'Show all transactions' filter button to display all transactions 5) Toggle the filter and note it works both ways Bonus points 1) Check that it works with and without online (paypal and plugin) payments enabled. 2) Check that it works with outstanding credits on the account.
Created attachment 94582 [details] [review] Bug 23633: Hide paid transactions by default on the OPAC This patch adds filtering on paid for type transactions to the OPAC accounts page. The filtering is enabled by default but may be toggled to show historical transactions. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 94646 [details] [review] Bug 23633: Hide paid transactions by default on the OPAC This patch adds filtering on paid for type transactions to the OPAC accounts page. The filtering is enabled by default but may be toggled to show historical transactions. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I really like this change. I'd also suggest to make 'show only unpaid' the default on the staff side too (separate bug).
Nice work! Pushed to master for 19.11.00