On the staff main page we should use font icons (Font Awesome) instead of sprite.png. These are easier to adjust/customize with CSS than the sprites we currently use.
Created attachment 93364 [details] [review] Bug 23711: Icons on staff main page should be font icons TEST PLAN: 1. GO to '/cgi-bin/koha/mainpage.pl' and observe the icons. 2. Apply the patch and clear the browser cache. 3. Refresh '/cgi-bin/koha/mainpage.pl' and make sure all the icons are still display. Note that some are not exactly the same as the old ones, but should be similar. Make sure you enable Course reserves and ILL so you can observe those icons as well.
I'm curious why you didn't use 'fa-tag' for cataloging? And 'fa-gift' for acquisitions? Also: misc/interface_customization/staff-home-icons-sprite.svg can be removed too.
Created attachment 93395 [details] [review] Bug 23711: Icons on staff main page should be font icons TEST PLAN: 1. GO to '/cgi-bin/koha/mainpage.pl' and observe the icons. 2. Apply the patch and clear the browser cache. 3. Refresh '/cgi-bin/koha/mainpage.pl' and make sure all the icons are still display. Note that some are not exactly the same as the old ones, but should be similar. Make sure you enable Course reserves and ILL so you can observe those icons as well.
Created attachment 93396 [details] [review] Bug 23711: Change icons and remove unused SVG
Created attachment 93403 [details] Screenshot
Created attachment 93439 [details] [review] Bug 23711: Icons on staff main page should be font icons Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Created attachment 93440 [details] [review] Bug 23711: Change icons and remove unused SVG Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Created attachment 93479 [details] [review] Bug 23711: Icons on staff main page should be font icons Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Created attachment 93480 [details] [review] Bug 23711: Change icons and remove unused SVG Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Created attachment 93481 [details] [review] Bug 23711: Fix bad path
Created attachment 93496 [details] [review] Bug 23711: Icons on staff main page should be font icons Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 93497 [details] [review] Bug 23711: Change icons and remove unused SVG Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 93498 [details] [review] Bug 23711: Fix bad path Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 93509 [details] [review] Bug 23711: Icons on staff main page should be font icons Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 93510 [details] [review] Bug 23711: Change icons and remove unused SVG Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 93511 [details] [review] Bug 23711: Fix bad path Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00