When exporting a basket group, the names of the files are different depending on the format chosen : if pdf, the aqbasketgroup.name is used ; if csv, it's the aqbasketgroup.id. I think it would be clearer for the users if names could be the same. My preference goes to the aqbasketgroup.name as it's the name chosen by librarians to ease acquisition management.
Created attachment 95531 [details] [review] Bug 23721: Use basketgroup's name to name the CSV export file When exporting a basket group, the names of the files are different: * pdf => aqbasketgroup.name(.pdf) * csv => aqbasketgroup.id(.csv) Better to use basketgroup's name for consistency and readability Test plan: Create a basketgroup and export it in pdf and CSV. The name of the generated file must be the basketgroup's name suffixed by the extension.
Created attachment 95540 [details] [review] Bug 23721: Use basketgroup's name to name the CSV export file When exporting a basket group, the names of the files are different: * pdf => aqbasketgroup.name(.pdf) * csv => aqbasketgroup.id(.csv) Better to use basketgroup's name for consistency and readability Test plan: Create a basketgroup and export it in pdf and CSV. The name of the generated file must be the basketgroup's name suffixed by the extension. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 95649 [details] [review] Bug 23721: Use basketgroup's name to name the CSV export file When exporting a basket group, the names of the files are different: * pdf => aqbasketgroup.name(.pdf) * csv => aqbasketgroup.id(.csv) Better to use basketgroup's name for consistency and readability Test plan: Create a basketgroup and export it in pdf and CSV. The name of the generated file must be the basketgroup's name suffixed by the extension. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work! Pushed to master for 19.11.00