In Bug 23108 is the comment “A user without the staffaccess permission cannot change the permissions or password for another user belonging to a patron category that is not type Staff. This works as intended.” Both the documentation and the on-screen explanation of this permission makes no mention that this permission is necessary to modify usernames or passwords. May I suggest that the description of the staffaccess permission be changed to read: “Allow staff members to modify permissions and usernames & passwords for other staff members”.
This appears fixed in newer versions: Allow staff members to modify permissions and passwords for other staff members
I realize, there is also username in the mix here. Reopening.
Created attachment 94961 [details] [review] Bug 23751: Make staffaccess permission description more precise The permission description was missing 'username' from the description. To test: - Look at the permissions of a patron - Verify the staffaccess permission is labelled: Allow staff members to modify permissions and passwords for other staff members - Apply patch - Check description again: Allow staff members to modify permissions, usernames, and passwords for other staff members
Created attachment 94993 [details] [review] Bug 23751: Make staffaccess permission description more precise The permission description was missing 'username' from the description. To test: - Look at the permissions of a patron - Verify the staffaccess permission is labelled: Allow staff members to modify permissions and passwords for other staff members - Apply patch - Check description again: Allow staff members to modify permissions, usernames, and passwords for other staff members Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 95142 [details] [review] Bug 23751: Make staffaccess permission description more precise The permission description was missing 'username' from the description. To test: - Look at the permissions of a patron - Verify the staffaccess permission is labelled: Allow staff members to modify permissions and passwords for other staff members - Apply patch - Check description again: Allow staff members to modify permissions, usernames, and passwords for other staff members Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work! Pushed to master for 19.11.00
backported to 19.05.x for 19.05.06