Hello, we could make expiry notices more louder. Some libraries've great experience with this kind of messages distributed by SMS. Borrowers react positive, more than by email.
I'm working on that. Marking as assigned
Created attachment 148123 [details] [review] Bug 23773: Send membership expiry notices by sms too Test plan: 1. Verify in "About" page that SMS::Send is installed. If not, install it. 2. Set system preferences: - SMSSendDriver = 'Test' - MembershipExpiryDaysNotice = 30 3. In "Notices and Slips" tool, edit the 'MEMBERSHIP_EXPIRY' letter and verify that both email and sms parts are filled. Use a different title and body for the sms part 4. Create a new borrower with an email address and an SMS number. Set their expiry date to a date next week 5. Run misc/cronjobs/membership_expiry.pl --confirm 6. Verify in the patron "Notices" tab that two notices are pending, one for email, one for sms Sponsored-by: Médiathèque de Montauban
Created attachment 148244 [details] [review] Bug 23773: Send membership expiry notices by sms too Test plan: 1. Verify in "About" page that SMS::Send is installed. If not, install it. 2. Set system preferences: - SMSSendDriver = 'Test' - MembershipExpiryDaysNotice = 30 3. In "Notices and Slips" tool, edit the 'MEMBERSHIP_EXPIRY' letter and verify that both email and sms parts are filled. Use a different title and body for the sms part 4. Create a new borrower with an email address and an SMS number. Set their expiry date to a date next week 5. Run misc/cronjobs/membership_expiry.pl --confirm 6. Verify in the patron "Notices" tab that two notices are pending, one for email, one for sms Sponsored-by: Médiathèque de Montauban Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
I've had a library ask for this and I thought it sounded familiar... I'll make a note to come back to this when I have more time.
Created attachment 150406 [details] [review] Bug 23773: Send membership expiry notices by sms too Test plan: 1. Verify in "About" page that SMS::Send is installed. If not, install it. 2. Set system preferences: - SMSSendDriver = 'Test' - MembershipExpiryDaysNotice = 30 3. In "Notices and Slips" tool, edit the 'MEMBERSHIP_EXPIRY' letter and verify that both email and sms parts are filled. Use a different title and body for the sms part 4. Create a new borrower with an email address and an SMS number. Set their expiry date to a date next week 5. Run misc/cronjobs/membership_expiry.pl --confirm 6. Verify in the patron "Notices" tab that two notices are pending, one for email, one for sms Sponsored-by: Médiathèque de Montauban Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
QA note: My initial reaction was to require a cli switch, but simply not having that notice will disable the feature from the UI, which is preferable.
Curious if this one will make it into 23.05
Pushed to master for 23.05. Nice work everyone, thanks!
Enhancement - not backporting to 22.11.x