+++ This bug was initially created as a clone of Bug #23772 +++ When looking at the new datatable for itemtypes, the itemtype icons are no longer displayed. The same happens, when editing an itemtype - the icon is no longer 'checked'. When you take a look at the db, the file names are there.
Created attachment 94017 [details] [review] Bug 23804: Correctly catch remote itemtype images Bug 20216 missed the mark and although it did start display a URL for the itemtype image in use, it was not limited to remote urls and as such broke the checked handling for displaying which local image was selected. Test plan: 1) Select a local image for an itemtype. 2) Check the correct image is displayed in the admin table. 3) Edit the itemtype checking that the correct image is checked. 4) Change to a remote image for the itemtype 5) Check the correct image is displayed in the admin table. 6) Edit the itemtype again and check that the URL still displays and is checked in the 'Remote image' tab. 7) Signoff
Created attachment 94028 [details] Images showing two issues identified 1) Weird display of remote image after patch applied 2) Images not displayed in table When testing this patch (which worked), I identified two issues: 1) After the patch is applied the remote image display is weird - after the input box and image there is an empty input box and the image is shown again (see issue 1 in attachment - shows before and after patch applied). 2) Not related to this bug, but does affect master. Images are not displayed in the image column (see issue 2 in attachment - shows images not displayed for current master (is the same before and after patch is applied), and for 19.05.x where it works correctly).
Argh! I see issue 2 is already a separate bug - 23772! (Issue 1 still applies though)
Created attachment 94210 [details] [review] Bug 23804: Correctly catch remote itemtype images Bug 20216 missed the mark and although it did start display a URL for the itemtype image in use, it was not limited to remote urls and as such broke the checked handling for displaying which local image was selected. Test plan: 1) Select a local image for an itemtype. 2) Check the correct image is displayed in the admin table. 3) Edit the itemtype checking that the correct image is checked. 4) Change to a remote image for the itemtype 5) Check the correct image is displayed in the admin table. 6) Edit the itemtype again and check that the URL still displays and is checked in the 'Remote image' tab. 7) Signoff
Patch updated to remove the image when no url is set. Also, bug 23772 is now pushed to the first issue is also resolved now.
Created attachment 94211 [details] [review] Bug 23804: Correctly catch remote itemtype images Bug 20216 missed the mark and although it did start display a URL for the itemtype image in use, it was not limited to remote urls and as such broke the checked handling for displaying which local image was selected. Test plan: 1) Select a local image for an itemtype. 2) Check the correct image is displayed in the admin table. 3) Edit the itemtype checking that the correct image is checked. 4) Change to a remote image for the itemtype 5) Check the correct image is displayed in the admin table. 6) Edit the itemtype again and check that the URL still displays and is checked in the 'Remote image' tab. 7) Signoff
Created attachment 94217 [details] [review] Bug 23804: Correctly catch remote itemtype images Bug 20216 missed the mark and although it did start display a URL for the itemtype image in use, it was not limited to remote urls and as such broke the checked handling for displaying which local image was selected. Test plan: 1) Select a local image for an itemtype. 2) Check the correct image is displayed in the admin table. 3) Edit the itemtype checking that the correct image is checked. 4) Change to a remote image for the itemtype 5) Check the correct image is displayed in the admin table. 6) Edit the itemtype again and check that the URL still displays and is checked in the 'Remote image' tab. 7) Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 94225 [details] [review] Bug 23804: Correctly catch remote itemtype images Bug 20216 missed the mark and although it did start display a URL for the itemtype image in use, it was not limited to remote urls and as such broke the checked handling for displaying which local image was selected. Test plan: 1) Select a local image for an itemtype. 2) Check the correct image is displayed in the admin table. 3) Edit the itemtype checking that the correct image is checked. 4) Change to a remote image for the itemtype 5) Check the correct image is displayed in the admin table. 6) Edit the itemtype again and check that the URL still displays and is checked in the 'Remote image' tab. 7) Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00
Depends on Bug 23602 not in 19.05.x