This is happening on 18.11.06: In this process, creating child guarantee does not populate Guarantor Information: 1. Create an Adult Patron 2. Create a New Patron - choosing a Child category 3. Add Surname, First Name, search for Guarantor in database- choose Guarantor. 4. Guarantor's address does not populate for Child Account. The way to do this which does work: 1. Create an Adult Patron 2. Click Add Child from Adult Patron's form. 3. Add surname, First name of Child 4. See the Guarantor's address is populated already. Can we adjust it so the first way works as the second way does?
That happen as a side-effect of bug 14570 "Make it possible to add multiple guarantors to a record" . The truth is when we have only one guarantor would be helpful to have some fields pre-filled.
Created attachment 100839 [details] [review] Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor Bug 14570 removed the guarantor pre-fill functionality when selecting 'Add guarantee' to an Adult patron. This is because guarantor information would now only display if (1) the patron record exists (which it won't when first adding guarantee to guarantor record) and (2) if there is already a guarantor added to a guarantee This patchfix will pre-fill guarantor fields if no relationship (existing guarantor data exists) and a guarantorid is handed to memberenty.pl in URL when clicking 'Add guarantee' button on Adults patron record. Test plan: 1. Add adult patron 2. Select 'Add guarantee' 3. Observe no details of the adult patron are displaying in the 'Guarantor information' section of the memberentry.pl page 4. Select 'Search to add', search for your adult patron and choose 'Select' to add them as guarantor 5. Fill out rest of memberentry.pl and 'Save' 6. Observe adult is showing as the guarantor 7. Apply patch 8. Run tests: sudo koha-shell <instancename> prove xt prove t 9. Confirm tests pass 10. Return to your adult patron 11. Select 'Add guarantee' 12. Observe in 'Guarantor information' section of memberentry.pl pre-filled is the 'patron #' (borrowernumber), surname, firstname 13. Fill out the rest of memberenty.pl and save and confirm your adult patron is showing as the guarantor 14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select 'Searcg to add' and add another adult as guarantor 15. Fill out the rest of memberentry.pl and 'Save' and notice with this patch applied you can still add multiple guarantors successfully Sponsored-By: South Taranaki Distict Libraries, NZ
Created attachment 100840 [details] [review] Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor Bug 14570 removed the guarantor pre-fill functionality when selecting 'Add guarantee' to an Adult patron. This is because guarantor information would now only display if (1) the patron record exists (which it won't when first adding guarantee to guarantor record) and (2) if there is already a guarantor added to a guarantee This patchfix will pre-fill guarantor fields if no relationship (existing guarantor data exists) and a guarantorid is handed to memberenty.pl in URL when clicking 'Add guarantee' button on Adults patron record. Test plan: 1. Add adult patron 2. Select 'Add guarantee' 3. Observe no details of the adult patron are displaying in the 'Guarantor information' section of the memberentry.pl page 4. Select 'Search to add', search for your adult patron and choose 'Select' to add them as guarantor 5. Fill out rest of memberentry.pl and 'Save' 6. Observe adult is showing as the guarantor 7. Apply patch 8. Run tests: sudo koha-shell <instancename> prove xt prove t 9. Confirm tests pass 10. Return to your adult patron 11. Select 'Add guarantee' 12. Observe in 'Guarantor information' section of memberentry.pl pre-filled is the 'patron #' (borrowernumber), surname, firstname 13. Fill out the rest of memberenty.pl and save and confirm your adult patron is showing as the guarantor 14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select 'Search to add' and add another adult as guarantor 15. Fill out the rest of memberentry.pl and 'Save' and notice with this patch applied you can still add multiple guarantors successfully Sponsored-By: South Taranaki Distict Libraries, NZ
Created attachment 100841 [details] [review] Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor Bug 14570 removed the guarantor pre-fill functionality when selecting 'Add guarantee' to an Adult patron. This is because guarantor information would now only display if (1) the patron record exists (which it won't when first adding guarantee to guarantor record) and (2) if there is already a guarantor added to a guarantee This patchfix will pre-fill guarantor fields if no relationship (existing guarantor data exists) and a guarantorid is handed to memberenty.pl in URL when clicking 'Add guarantee' button on Adults patron record. Test plan: 1. Add adult patron 2. Select 'Add guarantee' 3. Observe no details of the adult patron are displaying in the 'Guarantor information' section of the memberentry.pl page 4. Select 'Search to add', search for your adult patron and choose 'Select' to add them as guarantor 5. Fill out rest of memberentry.pl and 'Save' 6. Observe adult is showing as the guarantor 7. Apply patch 8. Run tests: sudo koha-shell <instancename> prove xt prove t 9. Confirm tests pass 10. Return to your adult patron 11. Select 'Add guarantee' 12. Observe in 'Guarantor information' section of memberentry.pl pre-filled is the 'patron #' (borrowernumber), surname, firstname 13. Fill out the rest of memberenty.pl and save and confirm your adult patron is showing as the guarantor 14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select 'Search to add' and add another adult as guarantor 15. Fill out the rest of memberentry.pl and 'Save' and notice with this patch applied you can still add multiple guarantors successfully Sponsored-By: South Taranaki Distict Libraries, NZ
Created attachment 100842 [details] [review] Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor Bug 14570 removed the guarantor pre-fill functionality when selecting 'Add guarantee' to an Adult patron. This is because guarantor information would now only display if (1) the patron record exists (which it won't when first adding guarantee to guarantor record) and (2) if there is already a guarantor added to a guarantee This patchfix will pre-fill guarantor fields if no relationship (existing guarantor data exists) and a guarantor_id is handed to memberenty.pl in URL when clicking 'Add guarantee' button on Adults patron record. Test plan: 1. Add adult patron 2. Select 'Add guarantee' 3. Observe no details of the adult patron are displaying in the 'Guarantor information' section of the memberentry.pl page 4. Select 'Search to add', search for your adult patron and choose 'Select' to add them as guarantor 5. Fill out rest of memberentry.pl and 'Save' 6. Observe adult is showing as the guarantor 7. Apply patch 8. Run tests: sudo koha-shell <instancename> prove xt prove t 9. Confirm tests pass 10. Return to your adult patron 11. Select 'Add guarantee' 12. Observe in 'Guarantor information' section of memberentry.pl pre-filled is the 'patron #' (borrowernumber), surname, firstname 13. Fill out the rest of memberenty.pl and save and confirm your adult patron is showing as the guarantor 14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select 'Search to add' and add another adult as guarantor 15. Fill out the rest of memberentry.pl and 'Save' and notice with this patch applied you can still add multiple guarantors successfully Sponsored-By: South Taranaki Distict Libraries, NZ
Hi all, I have replicated the bug behaviour George mentioned in comment #1 on master. Which is slightly different to what Kelly mentioned in 'Description'. Currently in master if you 'Add guarantee' from Adult's patron form then the guarantor/adults details are not pre-filled in the 'Guarantor information' section of memberentry.pl I've written a patch fix to solve that. Please have a test and let me know how you get on. Thanks, Alex
Created attachment 100844 [details] [review] Bug 23808: Added missing filter
Created attachment 100845 [details] [review] Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor Bug 14570 removed the guarantor pre-fill functionality when selecting 'Add guarantee' to an Adult patron. This is because guarantor information would now only display if (1) the patron record exists (which it won't when first adding guarantee to guarantor record) and (2) if there is already a guarantor added to a guarantee This patchfix will pre-fill guarantor fields and address fields (so the guarantee has the same address as the guarantor) if no relationship (existing guarantor data exists) and a guarantor_id is handed to memberenty.pl in URL when clicking 'Add guarantee' button on Adults patron record. Test plan: 1. Add adult patron make sure to fill in their 'Main address' details 2. Select 'Add guarantee' 3. Observe no details of the adult patron are displaying in the 'Guarantor information' section or 'Main address' sections of memberentry.pl 4. Select 'Search to add', search for your adult patron and choose 'Select' to add them as guarantor 5. Fill out rest of memberentry.pl and 'Save' 6. Observe adult is showing as the guarantor 7. Apply patch 8. Run tests: sudo koha-shell <instancename> prove xt prove t 9. Confirm tests pass 10. Return to your adult patron 11. Select 'Add guarantee' 12. Observe in 'Guarantor information' and 'Main address' sections of memberentry.pl are pre-filled with the 'patron #' (borrowernumber), surname, firstname and street number, address, address2 (if you filled that in on adults account), city 13. Fill out the rest of memberenty.pl and save and confirm your adult patron is showing as the guarantor and the pre-filled address details have been saved and are showing 14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select 'Search to add' and add another adult as guarantor 15. Fill out the rest of memberentry.pl and 'Save' and notice with this patch applied you can still add multiple guarantors successfully Sponsored-By: South Taranaki Distict Council, NZ
Sorry for the noise on this ticket with the patch fixes. I think it's finally ready to test :)
Created attachment 100889 [details] [review] Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor Bug 14570 removed the guarantor pre-fill functionality when selecting 'Add guarantee' to an Adult patron. This is because guarantor information would now only display if (1) the patron record exists (which it won't when first adding guarantee to guarantor record) and (2) if there is already a guarantor added to a guarantee This patchfix will pre-fill guarantor fields and address fields (so the guarantee has the same address as the guarantor) if no relationship (existing guarantor data exists) and a guarantor_id is handed to memberenty.pl in URL when clicking 'Add guarantee' button on Adults patron record. Test plan: 1. Add adult patron make sure to fill in their 'Main address' details 2. Select 'Add guarantee' 3. Observe no details of the adult patron are displaying in the 'Guarantor information' section or 'Main address' sections of memberentry.pl 4. Select 'Search to add', search for your adult patron and choose 'Select' to add them as guarantor 5. Fill out rest of memberentry.pl and 'Save' 6. Observe adult is showing as the guarantor 7. Apply patch 8. Run tests: sudo koha-shell <instancename> prove xt prove t 9. Confirm tests pass 10. Return to your adult patron 11. Select 'Add guarantee' 12. Observe in 'Guarantor information' and 'Main address' sections of memberentry.pl are pre-filled with the 'patron #' (borrowernumber), surname, firstname and street number, address, address2 (if you filled that in on adults account), city 13. Fill out the rest of memberenty.pl and save and confirm your adult patron is showing as the guarantor and the pre-filled address details have been saved and are showing 14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select 'Search to add' and add another adult as guarantor 15. Fill out the rest of memberentry.pl and 'Save' and notice with this patch applied you can still add multiple guarantors successfully Sponsored-By: South Taranaki Distict Council, NZ Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 100900 [details] [review] Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor Bug 14570 removed the guarantor pre-fill functionality when selecting 'Add guarantee' to an Adult patron. This is because guarantor information would now only display if (1) the patron record exists (which it won't when first adding guarantee to guarantor record) and (2) if there is already a guarantor added to a guarantee This patchfix will pre-fill guarantor fields and address fields (so the guarantee has the same address as the guarantor) if no relationship (existing guarantor data exists) and a guarantor_id is handed to memberenty.pl in URL when clicking 'Add guarantee' button on Adults patron record. Test plan: 1. Add adult patron make sure to fill in their 'Main address' details 2. Select 'Add guarantee' 3. Observe no details of the adult patron are displaying in the 'Guarantor information' section or 'Main address' sections of memberentry.pl 4. Select 'Search to add', search for your adult patron and choose 'Select' to add them as guarantor 5. Fill out rest of memberentry.pl and 'Save' 6. Observe adult is showing as the guarantor 7. Apply patch 8. Run tests: sudo koha-shell <instancename> prove xt prove t 9. Confirm tests pass 10. Return to your adult patron 11. Select 'Add guarantee' 12. Observe in 'Guarantor information' and 'Main address' sections of memberentry.pl are pre-filled with the 'patron #' (borrowernumber), surname, firstname and street number, address, address2 (if you filled that in on adults account), city 13. Fill out the rest of memberenty.pl and save and confirm your adult patron is showing as the guarantor and the pre-filled address details have been saved and are showing 14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select 'Search to add' and add another adult as guarantor 15. Fill out the rest of memberentry.pl and 'Save' and notice with this patch applied you can still add multiple guarantors successfully Sponsored-By: South Taranaki District Council, NZ Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: George Veranis <gveranis@dataly.gr> Followed the test plan, works as expected. The only failure was t/DateUtils.t test which will be fixed by Bug 24850. Also corrected a small typo in the sponsored-by trailer.
Would it make sense to reword the somewhat ambiguous "Patron #:" bit to read "Patron card number:" and also change the hyperlink to print the card number instead of the borrowernumber (leaving the link destination pointing to the borrowernumber)? From the point of view that it makes more sense for a Staff Interface user to view patrons' card numbers instead of a borrowernumber which is just a primary key in the DB and conveys little meaning to a regular user.
Created attachment 100925 [details] [review] Bug 23808: (follow-up) Display card number in 'Guarantor information' in memberentry.pl Instead of displaying 'Patron #' and displaying the guarantor's borrowernumber in 'Guarantor information' we should display 'Patron card number:' with the cardnumber displayed as that value is more meaningful to librarians. The hyperlink containing the borrowernumber should stay the same so that librarians can easily visit the patron record of existing guarantor patrons. Test plan: 1. Apply first patch and follow it's test plan 2. On an Adult patrons record select 'Add guarantee' 3. In 'Guarantor information' section of memberentry.pl observe in the pre-filled guarantor information there is a line 'Patron #:' with a link displaying a borrowernumber (not card number) and when you click on the link it takes you to the adult/guarantors patron account 4. Select 'Search to add' and search and add another guarantor 5. Observe in the added guarantor 'Patron #:' is displayed along with the borrowernumber (not card number). The borrowernumber displayed in not a link. 6. Apply this patch 7. On a adults patron select 'Add guarantee' 8. Observe in 'Guarantor information' section the pre-filled guarantor now has 'Patron card number:' displayed (instead of 'Patron #:', and it's link now displays the guarantors cardnumber. Clicking on the link still takes you to the guarantors patron account 9. Repeat step 4 10. Observe in the added guarantor they also have 'Patron card number:' (instead of 'Patron #:'). A cardnumber rather than borrowernumber is displayed. The cardnumber is not a link. 11. Confirm tests still pass: sudo koha-shell <instancename> prove xt prove t Sponsored-by: South Taranaki District Council, NZ
Hi all, Thanks very much everyone for testing! I agree Andreas displaying the card number would be more useful to librarians. I have attached a follow-up patch which does that. Please test and let me know what you think :) Many thanks, Alex
Created attachment 100928 [details] [review] Bug 23808: (follow-up) Display card number in 'Guarantor information' in memberentry.pl Pre-fill guarantee contact details (email, phone) from guarantor record when adding a gurantee to a guarantor's record Test plan: 1. Apply first two patches and follow test plans 2. On an adult's patron record (which has an primary phone number, secondary phone, other phone, primary email, secondary email and fax set) select 'Add a guarantee' and observe the guarantee's 'Contact' section is not pre-filled with that information from the guarantor 3. Apply this patch 4. On the same adult's record select 'Add a guarantee' and observe that the 'Primary phone', 'Secondary phone', 'Other phone', 'Primary email', 'Secondary email', 'Fax' have been pre-filled from the guarantor's record 5. Fill out the rest of the memberentry.pl and 'Save' and observe that those contact details are successfully saved 6. Repeat step 4 and alter the 'Primary phone' and 'Primary email' fields and save and observe that those altered values are saved 7. Run tests and confirm they pass: sudo koha-shell <instancename> prove xt prove t Sponsored-by: South Taranaki District Council, NZ
Created attachment 100929 [details] [review] Bug 23808: (follow-up) Pre-fill guarantee's contact details from guarantor patron in memberentry.pl Pre-fill guarantee contact details (email, phone) from guarantor record when adding a gurantee to a guarantor's record Test plan: 1. Apply first two patches and follow test plans 2. On an adult's patron record (which has an primary phone number, secondary phone, other phone, primary email, secondary email and fax set) select 'Add a guarantee' and observe the guarantee's 'Contact' section is not pre-filled with that information from the guarantor 3. Apply this patch 4. On the same adult's record select 'Add a guarantee' and observe that the 'Primary phone', 'Secondary phone', 'Other phone', 'Primary email', 'Secondary email', 'Fax' have been pre-filled from the guarantor's record 5. Fill out the rest of the memberentry.pl and 'Save' and observe that those contact details are successfully saved 6. Repeat step 4 and alter the 'Primary phone' and 'Primary email' fields and save and observe that those altered values are saved 7. Run tests and confirm they pass: sudo koha-shell <instancename> prove xt prove t Sponsored-by: South Taranaki District Council, NZ
Created attachment 100957 [details] [review] Bug 23808: (follow-up) Display card number in 'Guarantor information' in memberentry.pl Instead of displaying 'Patron #' and displaying the guarantor's borrowernumber in 'Guarantor information' we should display 'Patron card number:' with the cardnumber displayed as that value is more meaningful to librarians. The hyperlink containing the borrowernumber should stay the same so that librarians can easily visit the patron record of existing guarantor patrons. Test plan: 1. Apply first patch and follow it's test plan 2. On an Adult patrons record select 'Add guarantee' 3. In 'Guarantor information' section of memberentry.pl observe in the pre-filled guarantor information there is a line 'Patron #:' with a link displaying a borrowernumber (not card number) and when you click on the link it takes you to the adult/guarantors patron account 4. Select 'Search to add' and search and add another guarantor 5. Observe in the added guarantor 'Patron #:' is displayed along with the borrowernumber (not card number). The borrowernumber displayed in not a link. 6. Apply this patch 7. On a adults patron select 'Add guarantee' 8. Observe in 'Guarantor information' section the pre-filled guarantor now has 'Patron card number:' displayed (instead of 'Patron #:', and it's link now displays the guarantors cardnumber. Clicking on the link still takes you to the guarantors patron account 9. Repeat step 4 10. Observe in the added guarantor they also have 'Patron card number:' (instead of 'Patron #:'). A cardnumber rather than borrowernumber is displayed. The cardnumber is not a link. 11. Confirm tests still pass: sudo koha-shell <instancename> prove xt prove t Sponsored-by: South Taranaki District Council, NZ Signed-off-by: Andreas Roussos <a.roussos@dataly.gr>
Created attachment 100958 [details] [review] Bug 23808: (follow-up) Pre-fill guarantee's contact details from guarantor patron in memberentry.pl Pre-fill guarantee contact details (email, phone) from guarantor record when adding a gurantee to a guarantor's record Test plan: 1. Apply first two patches and follow test plans 2. On an adult's patron record (which has an primary phone number, secondary phone, other phone, primary email, secondary email and fax set) select 'Add a guarantee' and observe the guarantee's 'Contact' section is not pre-filled with that information from the guarantor 3. Apply this patch 4. On the same adult's record select 'Add a guarantee' and observe that the 'Primary phone', 'Secondary phone', 'Other phone', 'Primary email', 'Secondary email', 'Fax' have been pre-filled from the guarantor's record 5. Fill out the rest of the memberentry.pl and 'Save' and observe that those contact details are successfully saved 6. Repeat step 4 and alter the 'Primary phone' and 'Primary email' fields and save and observe that those altered values are saved 7. Run tests and confirm they pass: sudo koha-shell <instancename> prove xt prove t Sponsored-by: South Taranaki District Council, NZ Signed-off-by: Andreas Roussos <a.roussos@dataly.gr>
Alex, many thanks for following up on this so quickly! I have tested your new patches and they look good to me, so I signed them off. I also took the liberty of tagging some of the comments as obsolete, in order to unclutter the flow of the discussion in this bug report.
Thanks very much Andreas!
Created attachment 101098 [details] [review] Bug 23808: Pre-fill guarantor fields when adding guarantee to guarantor Bug 14570 removed the guarantor pre-fill functionality when selecting 'Add guarantee' to an Adult patron. This is because guarantor information would now only display if (1) the patron record exists (which it won't when first adding guarantee to guarantor record) and (2) if there is already a guarantor added to a guarantee This patchfix will pre-fill guarantor fields and address fields (so the guarantee has the same address as the guarantor) if no relationship (existing guarantor data exists) and a guarantor_id is handed to memberenty.pl in URL when clicking 'Add guarantee' button on Adults patron record. Test plan: 1. Add adult patron make sure to fill in their 'Main address' details 2. Select 'Add guarantee' 3. Observe no details of the adult patron are displaying in the 'Guarantor information' section or 'Main address' sections of memberentry.pl 4. Select 'Search to add', search for your adult patron and choose 'Select' to add them as guarantor 5. Fill out rest of memberentry.pl and 'Save' 6. Observe adult is showing as the guarantor 7. Apply patch 8. Run tests: sudo koha-shell <instancename> prove xt prove t 9. Confirm tests pass 10. Return to your adult patron 11. Select 'Add guarantee' 12. Observe in 'Guarantor information' and 'Main address' sections of memberentry.pl are pre-filled with the 'patron #' (borrowernumber), surname, firstname and street number, address, address2 (if you filled that in on adults account), city 13. Fill out the rest of memberenty.pl and save and confirm your adult patron is showing as the guarantor and the pre-filled address details have been saved and are showing 14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select 'Search to add' and add another adult as guarantor 15. Fill out the rest of memberentry.pl and 'Save' and notice with this patch applied you can still add multiple guarantors successfully Sponsored-By: South Taranaki District Council, NZ Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: George Veranis <gveranis@dataly.gr> Followed the test plan, works as expected. The only failure was t/DateUtils.t test which will be fixed by Bug 24850. Also corrected a small typo in the sponsored-by trailer. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 101099 [details] [review] Bug 23808: (follow-up) Display card number in 'Guarantor information' in memberentry.pl Instead of displaying 'Patron #' and displaying the guarantor's borrowernumber in 'Guarantor information' we should display 'Patron card number:' with the cardnumber displayed as that value is more meaningful to librarians. The hyperlink containing the borrowernumber should stay the same so that librarians can easily visit the patron record of existing guarantor patrons. Test plan: 1. Apply first patch and follow it's test plan 2. On an Adult patrons record select 'Add guarantee' 3. In 'Guarantor information' section of memberentry.pl observe in the pre-filled guarantor information there is a line 'Patron #:' with a link displaying a borrowernumber (not card number) and when you click on the link it takes you to the adult/guarantors patron account 4. Select 'Search to add' and search and add another guarantor 5. Observe in the added guarantor 'Patron #:' is displayed along with the borrowernumber (not card number). The borrowernumber displayed in not a link. 6. Apply this patch 7. On a adults patron select 'Add guarantee' 8. Observe in 'Guarantor information' section the pre-filled guarantor now has 'Patron card number:' displayed (instead of 'Patron #:', and it's link now displays the guarantors cardnumber. Clicking on the link still takes you to the guarantors patron account 9. Repeat step 4 10. Observe in the added guarantor they also have 'Patron card number:' (instead of 'Patron #:'). A cardnumber rather than borrowernumber is displayed. The cardnumber is not a link. 11. Confirm tests still pass: sudo koha-shell <instancename> prove xt prove t Sponsored-by: South Taranaki District Council, NZ Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 101100 [details] [review] Bug 23808: (follow-up) Pre-fill guarantee's contact details from guarantor patron in memberentry.pl Pre-fill guarantee contact details (email, phone) from guarantor record when adding a gurantee to a guarantor's record Test plan: 1. Apply first two patches and follow test plans 2. On an adult's patron record (which has an primary phone number, secondary phone, other phone, primary email, secondary email and fax set) select 'Add a guarantee' and observe the guarantee's 'Contact' section is not pre-filled with that information from the guarantor 3. Apply this patch 4. On the same adult's record select 'Add a guarantee' and observe that the 'Primary phone', 'Secondary phone', 'Other phone', 'Primary email', 'Secondary email', 'Fax' have been pre-filled from the guarantor's record 5. Fill out the rest of the memberentry.pl and 'Save' and observe that those contact details are successfully saved 6. Repeat step 4 and alter the 'Primary phone' and 'Primary email' fields and save and observe that those altered values are saved 7. Run tests and confirm they pass: sudo koha-shell <instancename> prove xt prove t Sponsored-by: South Taranaki District Council, NZ Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 101101 [details] [review] Bug 23808: (follow-up) Object methods can be used directly, no need for unblessed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Nice work everyone! Pushed to master for 20.05
Thanks very much everyone!
does not apply to 19.11.x. please rebase if needed.
Created attachment 105565 [details] [review] Bug 23808: [19.11.x] Pre-fill guarantor fields when adding guarantee to guarantor Bug 14570 removed the guarantor pre-fill functionality when selecting 'Add guarantee' to an Adult patron. This is because guarantor information would now only display if (1) the patron record exists (which it won't when first adding guarantee to guarantor record) and (2) if there is already a guarantor added to a guarantee This patchfix will pre-fill guarantor fields and address fields (so the guarantee has the same address as the guarantor) if no relationship (existing guarantor data exists) and a guarantor_id is handed to memberenty.pl in URL when clicking 'Add guarantee' button on Adults patron record. Test plan: 1. Add adult patron make sure to fill in their 'Main address' details 2. Select 'Add guarantee' 3. Observe no details of the adult patron are displaying in the 'Guarantor information' section or 'Main address' sections of memberentry.pl 4. Select 'Search to add', search for your adult patron and choose 'Select' to add them as guarantor 5. Fill out rest of memberentry.pl and 'Save' 6. Observe adult is showing as the guarantor 7. Apply patch 8. Run tests: sudo koha-shell <instancename> prove xt prove t 9. Confirm tests pass 10. Return to your adult patron 11. Select 'Add guarantee' 12. Observe in 'Guarantor information' and 'Main address' sections of memberentry.pl are pre-filled with the 'patron #' (borrowernumber), surname, firstname and street number, address, address2 (if you filled that in on adults account), city 13. Fill out the rest of memberenty.pl and save and confirm your adult patron is showing as the guarantor and the pre-filled address details have been saved and are showing 14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select 'Search to add' and add another adult as guarantor 15. Fill out the rest of memberentry.pl and 'Save' and notice with this patch applied you can still add multiple guarantors successfully Sponsored-By: South Taranaki District Council, NZ Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: George Veranis <gveranis@dataly.gr> Followed the test plan, works as expected. The only failure was t/DateUtils.t test which will be fixed by Bug 24850. Also corrected a small typo in the sponsored-by trailer. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 23808: (follow-up) Display card number in 'Guarantor information' in memberentry.pl Instead of displaying 'Patron #' and displaying the guarantor's borrowernumber in 'Guarantor information' we should display 'Patron card number:' with the cardnumber displayed as that value is more meaningful to librarians. The hyperlink containing the borrowernumber should stay the same so that librarians can easily visit the patron record of existing guarantor patrons. Test plan: 1. Apply first patch and follow it's test plan 2. On an Adult patrons record select 'Add guarantee' 3. In 'Guarantor information' section of memberentry.pl observe in the pre-filled guarantor information there is a line 'Patron #:' with a link displaying a borrowernumber (not card number) and when you click on the link it takes you to the adult/guarantors patron account 4. Select 'Search to add' and search and add another guarantor 5. Observe in the added guarantor 'Patron #:' is displayed along with the borrowernumber (not card number). The borrowernumber displayed in not a link. 6. Apply this patch 7. On a adults patron select 'Add guarantee' 8. Observe in 'Guarantor information' section the pre-filled guarantor now has 'Patron card number:' displayed (instead of 'Patron #:', and it's link now displays the guarantors cardnumber. Clicking on the link still takes you to the guarantors patron account 9. Repeat step 4 10. Observe in the added guarantor they also have 'Patron card number:' (instead of 'Patron #:'). A cardnumber rather than borrowernumber is displayed. The cardnumber is not a link. 11. Confirm tests still pass: sudo koha-shell <instancename> prove xt prove t Sponsored-by: South Taranaki District Council, NZ Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 23808: (follow-up) Pre-fill guarantee's contact details from guarantor patron in memberentry.pl Pre-fill guarantee contact details (email, phone) from guarantor record when adding a gurantee to a guarantor's record Test plan: 1. Apply first two patches and follow test plans 2. On an adult's patron record (which has an primary phone number, secondary phone, other phone, primary email, secondary email and fax set) select 'Add a guarantee' and observe the guarantee's 'Contact' section is not pre-filled with that information from the guarantor 3. Apply this patch 4. On the same adult's record select 'Add a guarantee' and observe that the 'Primary phone', 'Secondary phone', 'Other phone', 'Primary email', 'Secondary email', 'Fax' have been pre-filled from the guarantor's record 5. Fill out the rest of the memberentry.pl and 'Save' and observe that those contact details are successfully saved 6. Repeat step 4 and alter the 'Primary phone' and 'Primary email' fields and save and observe that those altered values are saved 7. Run tests and confirm they pass: sudo koha-shell <instancename> prove xt prove t Sponsored-by: South Taranaki District Council, NZ Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 23808: (follow-up) Object methods can be used directly, no need for unblessed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> fix tabs
I have tested this as we are hoping to have this rebase to happen so it can get pushed to 19.11. It is working!
*** Bug 25738 has been marked as a duplicate of this bug. ***
backported to 19.11.x for 19.11.07
Won't be backported to oldoldstable (19.05.x) considering it's severity (the level + a subjective perception) is not high enough and the patch is a bit to large. Unless there is a special need about this and some help to test it.
*** Bug 25741 has been marked as a duplicate of this bug. ***
*** Bug 25739 has been marked as a duplicate of this bug. ***