Bug 23812 - Download icon is an upload icon
Summary: Download icon is an upload icon
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-15 14:58 UTC by Cori Lynn Arnold
Modified: 2020-06-04 20:35 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00
Circulation function:

Attachments
Download icon points up (10.48 KB, image/jpeg)
2019-10-15 14:58 UTC, Cori Lynn Arnold 		Details
Bug 23812: Download icon is an upload icon (1.55 KB, patch)
2019-10-17 00:23 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 23812: Download icon is an upload icon (1.60 KB, patch)
2019-10-17 00:33 UTC, ByWater Sandboxes 		Details | Diff | Splinter Review
Bug 23812: Download icon is an upload icon (1.65 KB, patch)
2019-10-17 06:18 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cori Lynn Arnold 2019-10-15 14:58:37 UTC 
Created attachment 94218 [details]
Download icon points up

The Download button on the SQL Reports page is an upload icon (an arrow pointing up), can we change this to a download icon?
Comment 1 Lisette Scheer 2019-10-15 23:03:01 UTC 
Font awesome has a very similar download icon here:
https://fontawesome.com/icons/download?style=solid
Comment 2 Lucas Gass (lukeg) 2019-10-17 00:23:58 UTC 
Created attachment 94356 [details] [review]
Bug 23812: Download icon is an upload icon

test plan
1. run a report
2. the download icon is an upload icon
3. apply patch
4. the download icon is a download icon
Comment 3 ByWater Sandboxes 2019-10-17 00:33:00 UTC 
Created attachment 94357 [details] [review]
Bug 23812: Download icon is an upload icon

Signed-off-by: cori <corilynn.arnold@gmail.com>
Comment 4 Cori Lynn Arnold 2019-10-17 00:33:38 UTC 
Gorgeous! Thank you!
Comment 5 Katrin Fischer 2019-10-17 06:17:50 UTC 
Hi Cory, sandboxes don't switch the status always - please check and switch to "Signed off" manually when necessary!
Comment 6 Katrin Fischer 2019-10-17 06:18:37 UTC 
Created attachment 94360 [details] [review]
Bug 23812: Download icon is an upload icon

Signed-off-by: cori <corilynn.arnold@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Martin Renvoize (ashimema) 2019-10-17 13:54:47 UTC 
Nice work!

Pushed to master for 19.11.00